-
Notifications
You must be signed in to change notification settings - Fork 1
test: add integration tests and CI job #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dennis Zhuang <[email protected]>
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Signed-off-by: Dennis Zhuang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive integration tests for the GreptimeDB Java Ingester and a corresponding GitHub Actions CI job to run these tests. The integration tests cover regular write, streaming write, and bulk write APIs, with verification through JDBC queries.
Changes:
- Added a new Maven module
ingester-integration-testswith comprehensive test coverage for all write APIs - Created integration test helper utilities to manage test lifecycle and verification
- Added a GitHub Actions CI job that spins up a GreptimeDB Docker container and runs the integration tests
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Added the new ingester-integration-tests module to the parent POM |
| ingester-integration-tests/pom.xml | Maven configuration for the integration test module with necessary dependencies and failsafe plugin setup |
| ingester-integration-tests/src/test/resources/log4j2.xml | Log4j2 configuration for test logging |
| ingester-integration-tests/src/test/java/io/greptime/ITHelper.java | Helper utility class providing common test infrastructure |
| ingester-integration-tests/src/test/java/io/greptime/RegularWriteIT.java | Integration tests for regular write API |
| ingester-integration-tests/src/test/java/io/greptime/StreamingWriteIT.java | Integration tests for streaming write API |
| ingester-integration-tests/src/test/java/io/greptime/BulkWriteIT.java | Integration tests for bulk write API |
| .github/workflows/build.yml | Added CI job to run integration tests with a dockerized GreptimeDB instance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ingester-integration-tests/src/test/java/io/greptime/ITHelper.java
Outdated
Show resolved
Hide resolved
ingester-integration-tests/src/test/java/io/greptime/ITHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Zhuang <[email protected]>
fengjiachun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As the title said