Skip to content

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Sep 30, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Add the information_schema.ssts_index_meta virtual table to surface Puffin index metadata.
  • Extend the region server catalog to provide an in-memory table backed by the new index metadata entries.
  • Refresh information-schema SQL cases to cover index creation options and expected outputs.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@zhongzc zhongzc requested review from a team and v0y4g3r as code owners September 30, 2025 02:39
@github-actions github-actions bot added size/S docs-required This change requires docs update. labels Sep 30, 2025
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Sep 30, 2025
@killme2008
Copy link
Contributor

@zhongzc There are some sqlness failures.

@killme2008 killme2008 requested a review from Copilot October 9, 2025 07:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new information schema table ssts_index_meta to expose Puffin index metadata in GreptimeDB. It extends the existing information schema system to surface index metadata from SST files.

  • Add the information_schema.ssts_index_meta virtual table for Puffin index metadata
  • Extend region server catalog to provide in-memory table backed by index metadata entries
  • Update SQL test cases to cover new index creation options and verify expected outputs

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/store-api/src/sst_entry.rs Add build_plan method for PuffinIndexMetaEntry to support logical plan creation
src/datanode/src/region_server/catalog.rs Add index meta inspection support to region server catalog with new table provider
src/common/catalog/src/consts.rs Define table ID constant for the new ssts_index_meta information schema table
src/catalog/src/system_schema/information_schema/table_names.rs Add table name constant for ssts_index_meta
src/catalog/src/system_schema/information_schema/ssts.rs Implement InformationSchemaSstsIndexMeta struct with table provider functionality
src/catalog/src/system_schema/information_schema.rs Register new index meta table in information schema provider and add inspect kind
tests/cases/standalone/common/information_schema/ssts.sql Update test to include fulltext index and verify ssts_index_meta table functionality
tests/cases/standalone/common/information_schema/ssts.result Expected test output showing new table structure and index metadata
tests/cases/standalone/common/view/create.result Updated view creation test results including new ssts_index_meta table
tests/cases/standalone/common/system/information_schema.result Updated information schema test results with new table metadata
tests/cases/standalone/common/show/show_databases_tables.result Updated show tables test results including new ssts_index_meta table

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Base automatically changed from zhongzc/index-meta-api to main October 17, 2025 06:50
@zhongzc zhongzc requested a review from waynexia as a code owner October 17, 2025 06:50
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Oct 17, 2025
@zhongzc zhongzc force-pushed the zhongzc/index-meta-table branch from 0abe05d to bd84ecb Compare October 17, 2025 09:17
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Oct 17, 2025
@killme2008 killme2008 requested a review from Copilot October 17, 2025 09:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants