-
Notifications
You must be signed in to change notification settings - Fork 419
refactor: add peer_hostname
field in information_schema.cluster_info
table
#7050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4da371e
to
354ebd4
Compare
What’s the purpose of this field? Isn’t FYI: I recommend naming the table field |
Most of the time,
|
Signed-off-by: zyy17 <[email protected]>
Signed-off-by: zyy17 <[email protected]>
ccc0549
to
bcef0cd
Compare
hostname
field in information_schema.cluster_info
tablepeer_hostname
field in information_schema.cluster_info
table
d996598
to
0b33b63
Compare
Signed-off-by: zyy17 <[email protected]>
0b33b63
to
5b31c17
Compare
@sunng87, I added some |
Signed-off-by: zyy17 <[email protected]>
f8b3552
to
aba1b01
Compare
Signed-off-by: zyy17 <[email protected]>
aba1b01
to
8c4e0b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zyy17 <[email protected]>
ba71194
to
766447d
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Related greptime-proto PR: GreptimeTeam/greptime-proto#278.
Add
peer_hostname
field ininformation_schema.cluster_info
table.PR Checklist
Please convert it to a draft if some of the following conditions are not met.