Skip to content

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Oct 14, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

as title, fix a problem when projection cause table scan's output schema doesn't actually contain the partition columns, this case should be considered acceptable not as a hard error

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@discord9 discord9 requested a review from evenyag as a code owner October 14, 2025 11:43
@discord9 discord9 requested a review from waynexia October 14, 2025 11:43
@discord9 discord9 requested a review from WenyXu October 14, 2025 11:43
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 14, 2025
Co-authored-by: Yingwen <[email protected]>
Signed-off-by: discord9 <[email protected]>
@discord9 discord9 force-pushed the fix/no_partition_col_fix branch from d74a50c to 0fb3501 Compare October 15, 2025 02:39
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discord9 discord9 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into GreptimeTeam:main with commit 9aca7c9 Oct 16, 2025
42 checks passed
@discord9 discord9 deleted the fix/no_partition_col_fix branch October 16, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants