feat: writer mem limiter for http and grpc service #7092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jeremyhi <[email protected]>
fengjiachun
requested review from
a team,
waynexia and
zhongzc
as code owners
github-actions
bot
added
size/M
docs-not-required
Signed-off-by: jeremyhi <[email protected]>
| ## Set to 0 to disable limit. | ||
| body_limit = "64MB" | ||
| ## Maximum total memory for all concurrent HTTP request bodies. | ||
| ## Set to 0 to disable the limit. Default: "0" (unlimited) |
There was a problem hiding this comment.
better set a reasonable default, like 100MB, for better out-of-the-box user experience
Signed-off-by: jeremyhi <[email protected]>
Co-authored-by: LFC <[email protected]>
2 tasks
Signed-off-by: jeremyhi <[email protected]>
fengjiachun
force-pushed
the
feat/write_limiter
branch
from
2804bb9 to
997ecef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Add memory limiting for concurrent HTTP and gRPC requests to prevent unbounded memory growth from large concurrent write operations.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.