feat(repartition): implement validation logic for repartition table #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
docs-not-required
Signed-off-by: WenyXu <[email protected]>
WenyXu
force-pushed
the
feat/repartition-sql
branch
from
1bdbc75 to
516a516
Compare
WenyXu
changed the title
Signed-off-by: WenyXu <[email protected]>
fengjiachun
reviewed
Jan 8, 2026
Signed-off-by: WenyXu <[email protected]>
WenyXu
force-pushed
the
feat/repartition-sql
branch
from
115ad1a to
502a140
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements validation logic for table repartition operations (REPARTITION, SPLIT PARTITION, and MERGE PARTITION) in GreptimeDB. While the actual repartition execution is not yet implemented (returns "Not supported" error), the PR adds comprehensive validation that will be used when the feature is fully integrated.
Key changes:
- Added validation logic to check partition expressions before repartitioning
- Implemented checks for logical vs physical tables, partition column constraints, and partition expression validity
- Added comprehensive error test cases covering various failure scenarios
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/cases/standalone/common/alter/repartition_error.sql |
Test cases for repartition validation errors including logical table checks, non-partition column usage, non-existent partitions, incomplete rules, and overlapping partitions |
tests/cases/standalone/common/alter/repartition_error.result |
Expected error messages and results for the repartition error test cases |
src/table/src/metadata.rs |
Added partition_columns() helper method to return an iterator over partition column schemas |
src/operator/src/statement/ddl.rs |
Implemented repartition_table() function with validation logic for repartition operations including checks for logical tables, partition column validation, and partition expression validation |
src/operator/src/error.rs |
Added DeserializePartitionExpr error type for handling partition expression deserialization failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
waynexia
approved these changes
Jan 8, 2026
fengjiachun
approved these changes
Jan 8, 2026
linyihai
pushed a commit
to linyihai/greptimedb
that referenced
this pull request
Jan 28, 2026
…reptimeTeam#7538) * feat(repartition): implement validation logic for repartition_table Signed-off-by: WenyXu <[email protected]> * refactor: minor refactor Signed-off-by: WenyXu <[email protected]> * test: update sqlness Signed-off-by: WenyXu <[email protected]> --------- Signed-off-by: WenyXu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#6558
What's changed and what's your intention?
as title
PR Checklist
Please convert it to a draft if some of the following conditions are not met.