Skip to content

Conversation

@evenyag
Copy link
Contributor

@evenyag evenyag commented Jan 8, 2026

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds several metrics to ScanMetricsSet

  • add per partition convert cost metrics
  • add index result cache hit/miss for each index
  • distributor_divider_cost for series divider

Other improvements:

  • It fixes an issue that the puffin_metadata bytes were never added.
  • It unifies the scan cost between different scanners. Now the scan cost always contains the cost to build parts and readers.
  • It removes some unused fields from ScannerMetrics
  • It adds flat format flag in the explain verbose content

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@github-actions github-actions bot added size/S docs-not-required This change does not impact docs. labels Jan 8, 2026
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag marked this pull request as ready for review January 8, 2026 11:28
@evenyag evenyag requested review from a team, v0y4g3r and waynexia as code owners January 8, 2026 11:28
@waynexia
Copy link
Member

waynexia commented Jan 8, 2026

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag marked this pull request as draft January 8, 2026 16:32
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag marked this pull request as ready for review January 8, 2026 16:39
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag added this pull request to the merge queue Jan 13, 2026
Merged via the queue into GreptimeTeam:main with commit 4b3bd73 Jan 13, 2026
80 of 81 checks passed
@evenyag evenyag deleted the fix/convert-metrics branch January 13, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants