fix: validate range_fn when align not found #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
force-pushed
the
feature/fix-range-align-missing-error
branch
from
590e7a2 to
0afc2c2
Compare
killme2008
force-pushed
the
feature/fix-range-align-missing-error
branch
from
0afc2c2 to
b5feba1
Compare
5 tasks
evenyag
reviewed
Apr 23, 2025
Comment on lines
+10517
to
+10520
| if name.value.as_str() == "range_fn" { | ||
| let FunctionArguments::List(args) = &func.args else { | ||
| unreachable!() | ||
| }; |
There was a problem hiding this comment.
Can we ensure this is unreachable? If not, can we return an error here?
There was a problem hiding this comment.
We may use if-let or add a safety note that mentions which place ensures this.
evenyag
approved these changes
Apr 24, 2025
MichaelScofield
pushed a commit
that referenced
this pull request
May 7, 2025
MichaelScofield
pushed a commit
that referenced
this pull request
May 7, 2025
MichaelScofield
pushed a commit
that referenced
this pull request
Sep 29, 2025
MichaelScofield
pushed a commit
that referenced
this pull request
Oct 9, 2025
MichaelScofield
pushed a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GreptimeTeam/greptimedb#5957