fix: add recursive protection to Convert #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemingy
commented
Aug 3, 2025
kemingy
commented
- related to the bug in Crash when there are too many WHERE conditions in the SQL query greptimedb#6628
Signed-off-by: Keming <[email protected]>
|
cc @waynexia |
|
|
Several |
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
|
Spent some time to confirm these tests are broken since early versions. Let's get this merged. |
|
@kemingy could you update your patch in greptimedb repo to include this? thank you very much! |
Sure! |
Merged
5 tasks
|
Thank you @kemingy ❤️ |
MichaelScofield
added a commit
that referenced
this pull request
Aug 5, 2025
fix cargo fmt Merge branch 'v0.54.x' into v0.54.x Merge pull request #20 from kemingy/calc_overflow fix lint Merge branch 'v0.54.x' into v0.54.x Merge pull request #19 from kemingy/lint add test for statement convertion fix: overflow in the calculation expr fix the test in another pr fix overflow fix: lint and test fix: add recursive protection to Convert
MichaelScofield
added a commit
that referenced
this pull request
Sep 29, 2025
fix cargo fmt Merge branch 'v0.54.x' into v0.54.x Merge pull request #20 from kemingy/calc_overflow fix lint Merge branch 'v0.54.x' into v0.54.x Merge pull request #19 from kemingy/lint add test for statement convertion fix: overflow in the calculation expr fix the test in another pr fix overflow fix: lint and test fix: add recursive protection to Convert
MichaelScofield
added a commit
that referenced
this pull request
Oct 9, 2025
fix cargo fmt Merge branch 'v0.54.x' into v0.54.x Merge pull request #20 from kemingy/calc_overflow fix lint Merge branch 'v0.54.x' into v0.54.x Merge pull request #19 from kemingy/lint add test for statement convertion fix: overflow in the calculation expr fix the test in another pr fix overflow fix: lint and test fix: add recursive protection to Convert
MichaelScofield
added a commit
that referenced
this pull request
Oct 9, 2025
fix cargo fmt Merge branch 'v0.54.x' into v0.54.x Merge pull request #20 from kemingy/calc_overflow fix lint Merge branch 'v0.54.x' into v0.54.x Merge pull request #19 from kemingy/lint add test for statement convertion fix: overflow in the calculation expr fix the test in another pr fix overflow fix: lint and test fix: add recursive protection to Convert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.