fix: greywall setup downloads greyproxy binary instead of building from source#45
Closed
Joyce-O wants to merge 4 commits intoGreyhavenHQ:mainfrom
Closed
fix: greywall setup downloads greyproxy binary instead of building from source#45Joyce-O wants to merge 4 commits intoGreyhavenHQ:mainfrom
Joyce-O wants to merge 4 commits intoGreyhavenHQ:mainfrom
Conversation
Joyce-O
force-pushed
the
feat/fix-setup-and-docs
branch
3 times, most recently
from
53e1905 to
47ddc51
Compare
Joyce-O
force-pushed
the
feat/fix-setup-and-docs
branch
from
47ddc51 to
cbdf96c
Compare
Joyce-O
force-pushed
the
feat/fix-setup-and-docs
branch
5 times, most recently
from
e1744e6 to
18a5470
Compare
CheckLatestVersion was removed in favor of CheckLatestTag, but runSetup was missed. Also passes the resolved tag to Install so the upgrade installs the exact version that was checked.
Joyce-O
force-pushed
the
feat/fix-setup-and-docs
branch
from
18a5470 to
944cd40
Compare
Contributor
Author
|
No longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: greywall setup downloads greyproxy binary instead of building from source
Previously,
greywall setupcloned greyproxy and rango build, requiring a Go toolchain and failing silently without one. It now downloads the pre-built binary from GitHub Releases.Changes
internal/proxy/install.goInstall()downloads the latest stable release viafetchLatestRelease()fetchReleaseFor()— generic GitHub release fetcherIsOlderVersionnow accepts versions with or withoutvprefixCheckLatestTag()— fetches the latest stable release tag, used byrunSetupandrunCheckcmd/greywall/main.gorunSetupandrunCheckuseCheckLatestTaginstead of the oldCheckLatestVersionREADME.mdgreywall setupseparatelygreywall setuptogo installinstructionsTests
TestCheckLatestTag_OKandTestCheckLatestTag_APIError— version check via httptest server