Merged
Conversation
- Fix missing nolint:gosec comment on os.WriteFile in profiles edit command (same pattern as other uses of profilePath in the same block) - Add scripts/pre-commit hook that runs gofumpt check + golangci-lint; installed automatically via make setup or make install-hooks - Add fmt-check Makefile target (non-destructive, suitable for CI) - Replace golangci-lint-action in CI with make install-lint-tools && make fmt-check && make lint so the full codebase is always checked rather than only diff-incremental lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//nolint:goseconos.WriteFile(profilePath, ...)in the profiles edit command — same suppression pattern as every other use ofprofilePathin the same block, overlooked in feat: add profiles edit command #64scripts/pre-commithook that runsgofumptcheck +golangci-lint; installed automatically viamake setupormake install-hooksgolangci-lint-actionin CI (incremental/diff-only mode) withmake fmt-check && make lintso the full codebase is always checked on every PRRoot cause
golangci-lint-actiondefaults to--new-from-rev(incremental mode), which only lints lines changed in the PR diff. If a nolint comment is missing on a line that wasn't directly touched, it slips through. Runninggolangci-lint rundirectly always scans the full tree.Test plan
make fmt-checkpassesmake lintpasses (0 issues)make install-hookscopiesscripts/pre-committo.git/hooks/pre-commitmake fmt-check && make lint(check workflow diff)