Maya integration: fixed merge conflict#53
Maya integration: fixed merge conflict#53Ibm510000 wants to merge 1 commit intoGriddle-Assets:mainfrom
Conversation
| if (!stored) return; | ||
|
|
||
| const myPath = path.join(getDownloadFolder(), stored.folderName) | ||
| const pythonPath = path.join(__dirname,"../../../dcc/maya/MayaMiddleScript.py") |
There was a problem hiding this comment.
do we know if this works on an actual build? like are the python scripts actually included in the bundle?
There was a problem hiding this comment.
All the dcc files will be stored under the new folder root/dcc/ so griddle should be able to locate the python scripts.
There was a problem hiding this comment.
this needs to be set for each user..?
|
|
||
| if __name__ == "__main__": | ||
| a = sys.argv[1] | ||
| check = check_if_process_running("maya.exe") |
There was a problem hiding this comment.
does "maya.exe" work for mac or linux?
| await openFolder(asset_id); | ||
| return { ok: true }; | ||
| }, | ||
| 'assets:open-Maya': async (_, { asset_id}) => { |
There was a problem hiding this comment.
should probably change casing to "open-maya" to match other call names but not super important
| className="btn btn-ghost btn-sm flex w-full flex-row flex-nowrap items-center justify-start gap-2 text-sm font-normal" | ||
| onClick={onOpenMayaClick} | ||
| > | ||
| <MdFolderOpen /> |
There was a problem hiding this comment.
Icon or layout should be different to clarify different actions
printer83mph
left a comment
printer83mph
left a comment
There was a problem hiding this comment.
Could not get this running on my machine, on Mac for reference
Seems that "dir.txt" references a per-user location which should probably be automatically generated
Other small comments left on individual files
Unfortunately right now I don't think this is good to merge into main, but you should definitely show it working on your machine in class
3 participants
This merge fixed some merging bugs and is ready to merge