Migrate to MongoDB Doctrine ODM #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Jun 28, 2023
Collaborator
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Suggestion to use reference priming
| ->setParameter('now', new \DateTime()) | ||
| ; | ||
| $qb = $this->createQueryBuilder() | ||
| ->field('publishedAt')->lte(new \DateTimeImmutable()) // $$NOW is a MongoDB variable that returns the current date |
Collaborator
There was a problem hiding this comment.
You can use reference priming to eagerly load all referenced authors:
Suggested change
| ->field('publishedAt')->lte(new \DateTimeImmutable()) // $$NOW is a MongoDB variable that returns the current date | |
| ->field('publishedAt')->lte(new \DateTimeImmutable()) // $$NOW is a MongoDB variable that returns the current date | |
| ->field('author')->prime(true) |
Owner
Author
There was a problem hiding this comment.
It looks like primers are only supported for TYPE_FIND_AND_UPDATE and TYPE_FIND_AND_REMOVE queries. This is a TYPE_FIND query 😬
https://github.com/doctrine/mongodb-odm/blob/2.5.x/lib/Doctrine/ODM/MongoDB/Query/Query.php#L213-L231
Collaborator
There was a problem hiding this comment.
For queries of TYPE_FIND, this is done in makeIterator, which is called from runQuery: https://github.com/doctrine/mongodb-odm/blob/2.5.x/lib/Doctrine/ODM/MongoDB/Query/Query.php#L399..L402
- Upgrading masterminds/html5 (2.8.1 => 2.9.0) - Upgrading monolog/monolog (3.5.0 => 3.6.0) - Upgrading phpstan/phpstan-doctrine (1.3.64 => 1.3.65) - Upgrading phpstan/phpstan-symfony (1.3.9 => 1.3.12) - Upgrading symfony/cache (v7.0.4 => v7.0.6) - Upgrading symfony/cache-contracts (v3.4.0 => v3.4.2) - Upgrading symfony/config (v7.0.4 => v7.0.6) - Upgrading symfony/console (v7.0.4 => v7.0.6) - Upgrading symfony/dependency-injection (v7.0.4 => v7.0.6) - Upgrading symfony/doctrine-bridge (v7.0.5 => v7.0.6) - Upgrading symfony/error-handler (v7.0.4 => v7.0.6) - Upgrading symfony/event-dispatcher-contracts (v3.4.0 => v3.4.2) - Upgrading symfony/filesystem (v7.0.3 => v7.0.6) - Upgrading symfony/form (v7.0.4 => v7.0.6) - Upgrading symfony/framework-bundle (v7.0.4 => v7.0.6) - Upgrading symfony/http-client (v7.0.5 => v7.0.6) - Upgrading symfony/http-client-contracts (v3.4.0 => v3.4.2) - Upgrading symfony/http-foundation (v7.0.4 => v7.0.6) - Upgrading symfony/http-kernel (v7.0.5 => v7.0.6) - Upgrading symfony/mailer (v7.0.4 => v7.0.6) - Upgrading symfony/maker-bundle (v1.57.0 => v1.58.0) - Upgrading symfony/mime (v7.0.3 => v7.0.6) - Upgrading symfony/phpunit-bridge (v7.0.4 => v7.0.6) - Upgrading symfony/property-access (v7.0.4 => v7.0.6) - Upgrading symfony/property-info (v7.0.3 => v7.0.6) - Upgrading symfony/routing (v7.0.5 => v7.0.6) - Upgrading symfony/security-bundle (v7.0.5 => v7.0.6) - Upgrading symfony/service-contracts (v3.4.1 => v3.4.2) - Upgrading symfony/translation-contracts (v3.4.1 => v3.4.2) - Upgrading symfony/twig-bridge (v7.0.4 => v7.0.6) - Upgrading symfony/validator (v7.0.5 => v7.0.6) - Upgrading symfony/var-dumper (v7.0.4 => v7.0.6) - Upgrading symfony/var-exporter (v7.0.4 => v7.0.6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.