Conversation
91013b4 to
0ffa372
Compare
9a36d0d to
7ae5037
Compare
aea3a84 to
1394fca
Compare
1394fca to
dac268f
Compare
|
Hah, I was looking at resolving the type errors yesterday. Got sucked into another issue on a different library. |
|
Side note, is committing the generated docs useful anymore? 8 years ago it made sense, but now hexdocs is not going anywhere and regenerating them is fairly simple. |
|
Looks good. I haven't pored over every detail in this change, but it passes the tests in my PDF generator that uses this as a dependency and eliminates the warnings. |
| "ExImageInfo is an Elixir library to parse images (binaries) and get the dimensions (size), detected mime-type and overall validity for a set of image formats. It is the fastest and supports multiple formats.", | ||
| version: "VERSION" |> File.read!() |> String.trim(), | ||
| elixir: "~> 1.3", | ||
| elixir: "~> 1.13", |
There was a problem hiding this comment.
I wasn't sure about this bump, but I considered also this comment and the CI changes of this PR.
| [ | ||
| {:excoveralls, "~> 0.18", only: :test}, | ||
| {:ex_doc, "~> 0.30", only: :dev}, | ||
| {:ex_doc, "~> 0.37", only: :dev}, |
There was a problem hiding this comment.
Not really required these 2 version updates, as mix.lock is committed, but well, since all is for dev/test, updating it here as well.
| {:excoveralls, "~> 0.18", only: :test}, | ||
| {:ex_doc, "~> 0.30", only: :dev}, | ||
| {:ex_doc, "~> 0.37", only: :dev}, | ||
| {:inch_ex, "~> 2.0", only: [:dev, :test]}, |
There was a problem hiding this comment.
No repo updates in last 3 years, CI service is down (although badges work), has some warnings when compiling. I would consider if removing this along this year.
|
Did a bunch of changes, pinging again, and as any of you confirm it, I'll merge to have a new |
|
Moreover, fixing all the badges for ex_doc, as it does not have raw html support in markdown (while GitHub does). GitHub's rendered html. |
There was a problem hiding this comment.
Decided to remove this file as that service was ok for open source projects back then, but I have just quickly checked and it seems they only offer priced plans.

As mentioned in PR opened by @camelpunch, this PR solves that issue while keeping the same spec as the original intention provided by the code base.
I have been reviewing the specification and other libraries (go, zig and javascript), and keeping the
0x2F(magic byte) is the best way to go, than removing it (approach taken by the mentioned PR).Then, I have added Elixir 1.18 to the CI Test and Lint jobs (version matrix) and added
--warnings-as-errorsinmix compile.Correcting badges (README) and incorporating 3 new github action workflows as a replacement for Travis.
Finally, bumping versions of all dependencies.
58 Tests and 91.5% Code Coverage