Fix ClassUtil.externalClassVersion returning null for preview versions
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to that `checkVersionNumbers` previously said something like: > UnsupportedOperationException: Unsupported version number [69.0] (maximum 68.65535, Java null)
Marcono1234
commented
Oct 4, 2025
|
Think it's a good change, I'll wait to review after the release to fix #139 because I indeed want to check if Proguard is not affected more than I think of (we only use the API in these places but better safe than sorry). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to that previous behavior of
externalClassVersion,checkVersionNumberspreviously said something like:I guess this benefits also other callers of
externalClassVersion, but I am not sure if this could also have undesired side-effects for some of them (maybe also in https://github.com/Guardsquare/proguard).