Tracker/RFC: Bringing the YAML to PACT#20
Closed
evildarkarchon wants to merge 15 commits intoGuidanceOfGrace:mainfrom
Closed
Tracker/RFC: Bringing the YAML to PACT#20evildarkarchon wants to merge 15 commits intoGuidanceOfGrace:mainfrom
evildarkarchon wants to merge 15 commits intoGuidanceOfGrace:mainfrom
Conversation
This way, it won't instantly go from stopping to stopped. I also moved the xedit regex out of the function so it doesn't compile every time the while loop polls it.
Also, redid some code for correctness and removed some redundancies.
Contributor
Author
|
I hope I got the is_xedit_running change right, it's mostly improv with a little bit of chatbot assistance. I made that change because I wanted to remove an unnecessary regex. |
Also moved the lower-case mapped lists to the info dataclass.
Contributor
Author
|
Alright, at this point, it will actually run the cleaning loop and stop correctly, and add plugins to their proper ignore sections. |
Consolidated the code to identify if a process or file name is xedit or not into a single function. It also uses mapped sets of xedit_list_universal and xedit_list_specific that apply the str.lower() method to all entries. This way, it doesn't drag other processes that have edit at the end of their file name into the mix.
Contributor
Author
|
Superseded by #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by CLASSIC, I decided to convert as much as possible to YAML. I also organized the ignore list by game so that if, for example, a Skyrim and Fallout 4 plugin coincidentally had the same file name, it will only ignore it for the game that PACT is currently being run on.