Skip to content

Avoid unnecessary allocations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robinkrahl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid unnecessary allocations #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,20 +223,16 @@ impl MountInfo {
/// Check if a certain filesystem type is mounted at the given path.
pub fn contains<P: AsRef<Path>>(&self, mounting_point: P, fstype: FsType) -> bool {
let path = mounting_point.as_ref();
let filtered: Vec<&MountPoint> = self.mounting_points.iter().
filter(|mts|
mts.path == path.to_owned() && mts.fstype == fstype)
.collect();
filtered.len() > 0
self.mounting_points
.iter()
.any(|mts| &mts.path == path && mts.fstype == fstype)
}

/// Check if the given path is a mount point.
pub fn is_mounted<P: AsRef<Path>>(&self, path: P) -> bool {
let filtered: Vec<&MountPoint> = self.mounting_points.iter().
filter(|mts|
mts.path == path.as_ref().to_path_buf())
.collect();
filtered.len() > 0
self.mounting_points
.iter()
.any(|mts| &mts.path == path.as_ref())
}

fn parse_proc_mountinfo(file: &mut dyn std::io::Read) -> Result<Vec<MountPoint>, std::io::Error> {
Expand Down Expand Up @@ -331,4 +327,4 @@ mod test {
assert_eq!(more_options.read_write, ReadWrite::ReadOnly);
assert_ne!(more_options.others.len(), 0);
}
}
}