Skip to content

Conversation

@serikjensen
Copy link
Member

This PR

  • Updates to remove default components from GustoProviderCustomUIAdapter since that prevents tree shaking (this is ok for custom ui adapter since those components are all defined by the partner
  • Updates to use the exported adapter types file as the source of truth for adapter docs so that it includes pagination
  • Updates generate adapter docs script to account for individual types when present so things like the pagination items count is correctly documented

| **children** | `React.ReactNode` | No | Content to be displayed inside the heading |
| **className** | `string` | No | - |

## InputProps
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal component that isn't actually available for adapters, this correctly removes it

@jeffredodd
Copy link
Contributor

@copilot looks like CI got an error, can you fix it and open a PR to merge into this PR?

/home/runner/work/embedded-react-sdk/embedded-react-sdk/src/components/Payroll/ConfirmWireDetails/ConfirmWireDetails.tsx
  67:5  warning  Unused eslint-disable directive (no problems were reported from '@typescript-eslint/no-unsafe-call')

✖ 1 problem (0 errors, 1 warning)
  0 errors and 1 warning potentially fixable with the `--fix` option.


> @gusto/[email protected] format:check
> prettier . --check --log-level error

Copy link
Contributor

Copilot AI commented Dec 18, 2025

@jeffredodd I've opened a new pull request, #881, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

@jeffredodd jeffredodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once eslint build error is fixed. Sorry copilot couldn't do it.

@serikjensen
Copy link
Member Author

LGTM once eslint build error is fixed. Sorry copilot couldn't do it.

issue was prettier was failing. prettier fails on warn but was only configured to log errors. I updated prettier to log warnings and errors so we should have clearer CI output moving forward. Also updated the pre commit hook to just fix prettier in anticipation of the commit to preemptively solve it.

Should be updated now!

@serikjensen serikjensen merged commit fe52ac4 into main Dec 18, 2025
8 checks passed
@serikjensen serikjensen deleted the chore/SDK-252 branch December 18, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants