feat: add reusable usePagination hook #921
Merged
+260
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a reusable usePagination hook to centralize pagination logic across list components, improving code maintainability and consistency. The hook manages page navigation (first, previous, next, last) and items-per-page changes while extracting pagination metadata from HTTP response headers.
Key changes:
- New
usePaginationhook with page navigation handlers and state management extractPaginationMetautility for parsingx-total-pagesandx-total-countheaders with null-safe defaults- Comprehensive test suite with 15 tests covering state management, edge cases, and header extraction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/hooks/usePagination/usePagination.ts | Core hook implementation with navigation handlers and metadata extraction |
| src/hooks/usePagination/usePagination.test.ts | Complete test coverage for hook behavior and edge cases |
| src/hooks/usePagination/index.ts | Public API export for hook and utility function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeffredodd
requested review from
dmortal,
krisxcrash,
serikjensen and
shermango
jeffredodd
force-pushed
the
jdj/usePagination-hook
branch
from
761adba to
8b566cc
Compare
Member
|
Left feedback here around potentially moving state to inside the hook rather than passing it in |
jeffredodd
force-pushed
the
jdj/usePagination-hook
branch
from
8b566cc to
833fd6c
Compare
- Extract pagination logic into reusable hook - Add null-safety for undefined httpMeta - Include comprehensive unit tests
- Add parseHeaderInt helper with parseInt and NaN validation - Replace non-null assertions with optional chaining in tests - Add tests for invalid header values (NaN handling)
jeffredodd
force-pushed
the
jdj/usePagination-hook
branch
from
833fd6c to
634db48
Compare
Contributor
Author
Updated |
serikjensen
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new reusable
usePaginationhook that extracts pagination logic for use across list components.Changes
usePaginationhook with handlers for first/previous/next/last page navigationextractPaginationMetautility for parsing pagination headersTesting
npm run test -- --run src/hooks/usePagination/Follow-up PRs
This is PR 1 of 3 for the pagination improvements: