Support Rack 3 (attempt #2)

.github/workflows/tests.yml → .github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: Test Suite
+name: CI
 
 on:
   push:
@@ -16,10 +16,10 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v2
 
-      - name: Set up Ruby 2.7
+      - name: Set up Ruby 3.4
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.4
 
       - name: Install Docker and Docker Compose
         run: |
@@ -35,4 +35,8 @@ jobs:
         run: gem install rake rspec
 
       - name: Run tests
-        run: rake
+        run: |
+          rake compile_protos_ruby
+          rake compile_js_client
+          rake compile_node_client
+          rake run_specs_in_docker

.gitignore

@@ -8,6 +8,8 @@ coverage
 
 node_modules
 .bundle
+.yarn*
 
 # Workspace
 .idea
+mise.toml

.rubocop.yml

@@ -1,4 +1,4 @@
-require: rubocop-rspec
+plugins: rubocop-rspec
 inherit_from: .rubocop_todo.yml
 
 AllCops:
@@ -61,5 +61,5 @@ RSpec/ExampleLength:
   Max: 15
 RSpec/NestedGroups:
   Max: 5
-RSpec/FilePath:
-  Enabled: false
+# RSpec/FilePath:
+  # Enabled: false

.ruby-version

@@ -1 +1 @@
-2.7.8
+3.4.2

Dockerfile

@@ -1,11 +1,9 @@
-FROM ruby:2.7.8
+FROM ruby:3.4.2
 
-# Install dependency packages
 RUN apt-get update && apt-get install -y \
   chromium \
   chromium-driver \
   curl \
-  fonts-liberation \
   libappindicator3-1 \
   libasound2 \
   libatk-bridge2.0-0 \
@@ -27,24 +25,29 @@ RUN apt-get update && apt-get install -y \
   libxrandr2 \
   libxss1 \
   libxtst6 \
-  nodejs \
   xdg-utils
 
-# Install Yarn
-ENV PATH=/root/.yarn/bin:$PATH
-RUN touch ~/.bashrc && \
-    curl -o- -L https://yarnpkg.com/install.sh | sh
+# Install Node, Yarn (but don't set version berry yet - that creates package.json in cwd)
+RUN curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \
+  && bash nodesource_setup.sh \
+  && apt-get install -y nodejs \
+  && npm i -g corepack \
+  && corepack enable \
+  && corepack prepare yarn
 
 # Setup project home directory
 RUN mkdir /app
 WORKDIR /app
 
+# Now set yarn version in /app to avoid creating /package.json at root
+RUN yarn set version berry \
+  && yarn config set --home enableTelemetry 0
+
 # Add Gemfile and cache results of bundle install
 COPY .ruby-version grpc-web.gemspec Gemfile Gemfile.lock /app/
 COPY lib/grpc_web/version.rb /app/lib/grpc_web/
 
-RUN gem install bundler -v 2.4.22 \
- && bundle config --global frozen 1 \
- && bundle install -j4 --retry 3 \
+RUN gem install bundler \
+ && bundle update -j4 --retry 3 \
  # Remove unneeded files (cached *.gem, *.o, *.c)
  && rm -rf /usr/local/bundle/cache/*.gem

Dockerfile.protoc

@@ -0,0 +1,30 @@
+FROM namely/protoc-all:latest
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+RUN apt-get update && apt-get -y -o Dpkg::Options::="--force-confold" install \
+  unzip \
+  ruby
+
+RUN gem install grpc-tools
+
+RUN curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \
+  && bash nodesource_setup.sh \
+  && apt-get -y -o Dpkg::Options::="--force-confold" install nodejs \
+  && npm i -g npm \
+  && npm i -g ts-protoc-gen --force \
+  && npm i -g protoc-gen-js
+
+RUN PROTOC_ZIP=protoc-28.0-linux-x86_64.zip \
+  && curl -OL https://github.com/protocolbuffers/protobuf/releases/download/v28.0/$PROTOC_ZIP \
+  && unzip -o $PROTOC_ZIP -d /usr/local bin/protoc \
+  && unzip -o $PROTOC_ZIP -d /usr/local 'include/*' \
+  && rm -f $PROTOC_ZIP
+
+# Install modern protoc-gen-grpc-web plugin (compatible with grpc-web 1.5.0+)
+RUN GRPC_WEB_VERSION=1.5.0 \
+  && curl -OL https://github.com/grpc/grpc-web/releases/download/${GRPC_WEB_VERSION}/protoc-gen-grpc-web-${GRPC_WEB_VERSION}-linux-x86_64 \
+  && mv protoc-gen-grpc-web-${GRPC_WEB_VERSION}-linux-x86_64 /usr/local/bin/protoc-gen-grpc-web \
+  && chmod +x /usr/local/bin/protoc-gen-grpc-web
+
+ENTRYPOINT []

Gemfile.lock

@@ -2,18 +2,20 @@ PATH
   remote: .
   specs:
     grpc-web (1.2.1)
-      google-protobuf (~> 3.13.0)
-      grpc (~> 1.0)
-      rack (>= 1.6.0, < 3.0)
+      base64
+      google-protobuf
+      grpc
+      rack (>= 3, <= 4)
 
 GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.3)
+    base64 (0.3.0)
     bigdecimal (3.1.9)
-    byebug (11.1.3)
+    byebug (12.0.0)
     capybara (3.39.2)
       addressable
       matrix
@@ -29,52 +31,64 @@ GEM
       rexml
     diff-lcs (1.6.1)
     docile (1.4.1)
-    google-protobuf (3.13.0)
-    google-protobuf (3.13.0-universal-darwin)
-    google-protobuf (3.13.0-x86_64-linux)
-    googleapis-common-protos-types (1.0.5)
-      google-protobuf (~> 3.11)
-    grpc (1.34.0)
-      google-protobuf (~> 3.13)
+    google-protobuf (4.30.2)
+      bigdecimal
+      rake (>= 13)
+    google-protobuf (4.30.2-aarch64-linux)
+      bigdecimal
+      rake (>= 13)
+    google-protobuf (4.30.2-arm64-darwin)
+      bigdecimal
+      rake (>= 13)
+    google-protobuf (4.30.2-x86_64-linux)
+      bigdecimal
+      rake (>= 13)
+    googleapis-common-protos-types (1.19.0)
+      google-protobuf (>= 3.18, < 5.a)
+    grpc (1.76.0)
+      google-protobuf (>= 3.25, < 5.0)
       googleapis-common-protos-types (~> 1.0)
-    grpc (1.34.0-universal-darwin)
-      google-protobuf (~> 3.13)
+    grpc (1.76.0-aarch64-linux-gnu)
+      google-protobuf (>= 3.25, < 5.0)
       googleapis-common-protos-types (~> 1.0)
-    grpc (1.34.0-x86_64-linux)
-      google-protobuf (~> 3.13)
+    grpc (1.76.0-arm64-darwin)
+      google-protobuf (>= 3.25, < 5.0)
+      googleapis-common-protos-types (~> 1.0)
+    grpc (1.76.0-x86_64-linux-gnu)
+      google-protobuf (>= 3.25, < 5.0)
       googleapis-common-protos-types (~> 1.0)
     hashdiff (1.1.2)
-    jaro_winkler (1.5.6)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.7.0)
     matrix (0.4.2)
     method_source (1.1.0)
     mini_mime (1.1.5)
     mini_portile2 (2.8.9)
     nokogiri (1.15.7)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.15.7-aarch64-linux)
-      racc (~> 1.4)
-    nokogiri (1.15.7-arm64-darwin)
-      racc (~> 1.4)
-    nokogiri (1.15.7-x86_64-linux)
-      racc (~> 1.4)
-    parallel (1.26.3)
-    parser (3.3.7.4)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
-    pry (0.14.2)
+    prism (1.4.0)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.10.1)
-      byebug (~> 11.0)
-      pry (>= 0.13, < 0.15)
+    pry-byebug (3.11.0)
+      byebug (~> 12.0)
+      pry (>= 0.13, < 0.16)
     public_suffix (5.1.1)
     racc (1.8.1)
-    rack (2.2.13)
+    rack (3.1.13)
     rack-cors (2.0.2)
       rack (>= 2.0.0)
     rack-test (2.2.0)
       rack (>= 1.3)
+    rackup (2.3.1)
+      rack (>= 3)
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.10.0)
@@ -92,18 +106,28 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.2)
-    rubocop (0.79.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (1.75.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-rspec (1.41.0)
-      rubocop (>= 0.68.1)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
     rubyzip (2.4.1)
-    selenium-webdriver (4.9.0)
+    selenium-webdriver (4.31.0)
+      base64 (~> 0.2)
+      logger (~> 1.4)
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
       websocket (~> 1.0)
@@ -113,11 +137,14 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    unicode-display_width (1.6.1)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     webmock (3.25.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
+    webrick (1.9.2)
     websocket (1.2.11)
     xpath (3.2.0)
       nokogiri (~> 1.8)
@@ -133,13 +160,15 @@ DEPENDENCIES
   grpc-web!
   pry-byebug
   rack-cors
+  rackup
   rake
-  rspec (~> 3.3)
-  rubocop (~> 0.79.0)
+  rspec
+  rubocop
   rubocop-rspec
   selenium-webdriver
   simplecov
   webmock
+  webrick
 
 BUNDLED WITH
    2.4.22