Skip to content

Conversation

@joemsak
Copy link
Contributor

@joemsak joemsak commented Dec 10, 2025

What

Fixes yarn workspace isolation for the spec/node-client directory so yarn works correctly without needing an npm workaround.

Why

With Yarn 4 (packageManager: [email protected] in root), running yarn in nested directories caused workspace detection issues. The previous workaround ran npm install --silent 2>/dev/null on every test execution, which was slow and hid errors.

How

  • Add .yarnrc.yml to spec/node-client/ marking it as a standalone Yarn project
  • Add root .yarnrc.yml to git (previously ignored)
  • Update .gitignore to be more specific (.yarn/ instead of .yarn*)
  • Remove the per-test npm install workaround
  • Delete package-lock.json from node-client (use yarn consistently)

Change .yarn* to .yarn/ and .pnp.* to be more specific.
This allows .yarnrc.yml configuration files to be tracked.
Add standalone .yarnrc.yml to spec/node-client/ so Yarn 4 treats it
as an independent project rather than detecting it as a workspace
member of the root project.
With yarn workspace isolation fixed, we no longer need to run
npm install on every test run. The test now just executes the
pre-built node client directly.

- Remove npm install command from test
- Delete package-lock.json (use yarn consistently)
- Update yarn.lock files
@joemsak joemsak marked this pull request as ready for review December 10, 2025 20:26
@joemsak joemsak changed the base branch from unpin-rack-mattbooks to master December 10, 2025 20:27
@joemsak joemsak marked this pull request as draft December 10, 2025 20:27
@socket-security
Copy link

Caution

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. For more information please check in at #security-help. For License Policy Violations please also tag @Aoife in #security-help.

Action Severity Alert  (click "▶" to expand/collapse)
Block High
License policy violation: gem diff-lcs under GPL-2.0+

License: GPL-2.0+ - the applicable license policy does not allow this license (4) (docs/COPYING.txt)

License: GPL-2.0-or-later - the applicable license policy does not allow this license (4) (Ruby Gem Metadata)

License: Artistic-1.0-Perl - the applicable license policy does not allow this license (4) (Ruby Gem Metadata)

From: Gemfile.lockgem/[email protected]gem/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore gem/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block High
License policy violation: gem grpc under APSL-2.0

License: APSL-2.0 - the applicable license policy does not allow this license (4) (third_party/cares/cares/src/lib/thirdparty/apple/dnsinfo.h)

From: Gemfile.lockgem/[email protected]gem/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore gem/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block High
License policy violation: gem nokogiri under GPL-2.0-only

License: GPL-2.0-only - the applicable license policy does not allow this license (4) (patches/libxml2/0010-update-config.guess-and-config.sub-for-libxml2.patch)

License: GPL-2.0-only - the applicable license policy does not allow this license (4) (patches/libxslt/0001-update-config.guess-and-config.sub-for-libxslt.patch)

From: Gemfile.lockgem/[email protected]gem/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore gem/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block High
License policy violation: gem public_suffix under MIT AND MPL-2.0

Location: Package overview

From: Gemfile.lockgem/[email protected]gem/[email protected]gem/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore gem/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block High
License policy violation: npm typescript

License: LicenseRef-W3C-Community-Final-Specification-Agreement - the applicable license policy does not allow this license (4) (package/ThirdPartyNoticeText.txt)

From: spec/node-client/package.jsonnpm/[email protected]

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm npm is 94.0% likely obfuscated

Confidence: 0.94

Location: Package overview

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@joemsak joemsak changed the base branch from master to unpin-rack-mattbooks December 10, 2025 20:31
@joemsak joemsak changed the title [Testing] Fix yarn workspace isolation for node-client Fix yarn workspace isolation for node-client Dec 10, 2025
@joemsak joemsak marked this pull request as ready for review December 10, 2025 20:34
@mattbooks mattbooks merged commit 3e9bea2 into unpin-rack-mattbooks Dec 10, 2025
8 of 9 checks passed
@mattbooks mattbooks deleted the jms/unpin-rack-mattbooks branch December 10, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants