-
Notifications
You must be signed in to change notification settings - Fork 6
Fix yarn workspace isolation for node-client #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change .yarn* to .yarn/ and .pnp.* to be more specific. This allows .yarnrc.yml configuration files to be tracked.
Add standalone .yarnrc.yml to spec/node-client/ so Yarn 4 treats it as an independent project rather than detecting it as a workspace member of the root project.
With yarn workspace isolation fixed, we no longer need to run npm install on every test run. The test now just executes the pre-built node client directly. - Remove npm install command from test - Delete package-lock.json (use yarn consistently) - Update yarn.lock files
|
Caution According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. For more information please check in at #security-help. For License Policy Violations please also tag @Aoife in #security-help.
|
What
Fixes yarn workspace isolation for the
spec/node-clientdirectory so yarn works correctly without needing an npm workaround.Why
With Yarn 4 (
packageManager: [email protected]in root), running yarn in nested directories caused workspace detection issues. The previous workaround rannpm install --silent 2>/dev/nullon every test execution, which was slow and hid errors.How
.yarnrc.ymltospec/node-client/marking it as a standalone Yarn project.yarnrc.ymlto git (previously ignored).gitignoreto be more specific (.yarn/instead of.yarn*)npm installworkaroundpackage-lock.jsonfrom node-client (use yarn consistently)