Skip to content

fix(integration): Material Social Card URI was wrong for Material blog posts when diretcory URL are disabled at Mkdocs level #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guts merged 1 commit into from
Jan 5, 2026
Merged

fix(integration): Material Social Card URI was wrong for Material blog posts when diretcory URL are disabled at Mkdocs level #420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions mkdocs_rss_plugin/integrations/theme_material_social_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def __init__(self, mkdocs_config: MkDocsConfig, switch_force: bool = True) -> No

# if enabled, save some config elements
if self.IS_ENABLED:
self.mkdocs_use_directory_urls = mkdocs_config.use_directory_urls
self.mkdocs_site_url = mkdocs_config.site_url
self.mkdocs_site_build_dir = mkdocs_config.site_dir
self.social_cards_dir = self.get_social_cards_dir(
Expand All @@ -99,10 +100,6 @@ def __init__(self, mkdocs_config: MkDocsConfig, switch_force: bool = True) -> No

self.load_cache_cards_manifest()

# store some attributes used to compute social card hash
self.site_name = mkdocs_config.site_name
self.site_description = mkdocs_config.site_description or ""

def is_social_plugin_enabled_mkdocs(
self, mkdocs_config: MkDocsConfig | None = None
) -> bool:
Expand Down Expand Up @@ -383,10 +380,17 @@ def get_social_card_url_for_page(
self.integration_material_blog.IS_BLOG_PLUGIN_ENABLED
and self.integration_material_blog.is_page_a_blog_post(mkdocs_page)
):
page_social_card = (
f"{mkdocs_site_url}assets/images/social/"
f"{Path(mkdocs_page.dest_uri).with_suffix('.png')}"
)
if self.mkdocs_use_directory_urls:
# see: https://github.com/Guts/mkdocs-rss-plugin/issues/319
page_social_card = (
f"{mkdocs_site_url}{self.social_cards_dir}/"
f"{Path(mkdocs_page.dest_uri).parent.with_suffix('.png')}"
)
else:
page_social_card = (
f"{mkdocs_site_url}{self.social_cards_dir}/"
f"{Path(mkdocs_page.dest_uri).with_suffix('.png')}"
)
else:
page_social_card = (
f"{mkdocs_site_url}{self.social_cards_dir}/"
Expand Down