Merge pull request #982 from Medo42/patch-1

Fix #981: DOM breakage in MaterialListValueBox

Author: kevzlou7979

README.md

@@ -20,20 +20,20 @@ We created <a href="http://gwtmaterialdesign.github.io/gwt-material-demo/apidocs
 
 
 ## Maven
-### Current Version 2.4.0-rc2
+### Current Version 2.4.0
 ```xml
 <dependency>
     <groupId>com.github.gwtmaterialdesign</groupId>
     <artifactId>gwt-material</artifactId>
-    <version>2.4.0-rc2</version>
+    <version>2.4.0</version>
 </dependency>
 ```
-### Snapshot Version 2.4.0-SNAPSHOT
+### Snapshot Version 2.5.0-SNAPSHOT
 ```xml
 <dependency>
     <groupId>com.github.gwtmaterialdesign</groupId>
     <artifactId>gwt-material</artifactId>
-    <version>2.4.0-SNAPSHOT</version>
+    <version>2.5.0-SNAPSHOT</version>
 </dependency>
 ```
 
@@ -52,9 +52,6 @@ Contributions are welcomed by all! If you would like to submit changes be sure t
 
 Please follow the [contribution document](https://github.com/GwtMaterialDesign/gwt-material/wiki/Contributing) on the projects code style standards.
 
-## Follow Us
-<a href="https://plus.google.com/u/0/communities/108005250093449814286"> Google Plus</a>
-
 ## Related Projects
 <ul>
  <li><a href="https://github.com/GwtMaterialDesign/gwt-material-addins" >Addins</a></li>

gwt-material/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <artifactId>gwt-material-parent</artifactId>
         <groupId>com.github.gwtmaterialdesign</groupId>
-        <version>2.4.0-SNAPSHOT</version>
+        <version>2.4.0</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

gwt-material/src/main/java/gwt/material/design/client/base/AbstractSideNav.java

@@ -56,7 +56,7 @@
  */
 //@formatter:on
 public abstract class AbstractSideNav extends MaterialWidget
-        implements JsLoader, HasSelectables, HasInOutDurationTransition, HasSideNavHandlers, HasOverlayStyle, HasDensity {
+        implements JsLoader, HasSelectables, HasInOutDurationTransition, HasSideNavHandlers, HasOverlayStyle, HasOpenClose, HasDensity {
 
     protected int width = 240;
     protected int inDuration = 400;
@@ -482,6 +482,7 @@ public void show() {
     /**
      * Show the sidenav using the activator element
      */
+    @Override
     public void open() {
         $("#sidenav-overlay").remove();
         $(activator).sideNav("show");
@@ -498,10 +499,12 @@ public void hide() {
     /**
      * Hide the sidenav using the activator element
      */
+    @Override
     public void close() {
         $(activator).sideNav("hide");
     }
 
+    @Override
     public boolean isOpen() {
         return open;
     }

gwt-material/src/main/java/gwt/material/design/client/base/HasOpenClose.java

@@ -0,0 +1,29 @@
+/*
+ * #%L
+ * GwtMaterial
+ * %%
+ * Copyright (C) 2015 - 2020 GwtMaterialDesign
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * #L%
+ */
+package gwt.material.design.client.base;
+
+public interface HasOpenClose {
+
+    void open();
+
+    void close();
+
+    boolean isOpen();
+}

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialDatePicker.java

@@ -67,7 +67,7 @@
 //@formatter:on
 public class MaterialDatePicker extends AbstractValueWidget<Date> implements JsLoader, HasPlaceholder,
     HasOpenHandlers<MaterialDatePicker>, HasCloseHandlers<MaterialDatePicker>, HasIcon, HasReadOnly,
-    HasFieldTypes, HasLabel {
+    HasFieldTypes, HasLabel, HasOpenClose {
 
     /**
      * Enum for identifying various selection types for the picker.
@@ -636,17 +636,20 @@ public MaterialLabel getErrorLabel() {
     /**
      * Programmatically close the date picker component
      */
+    @Override
     public void close() {
         Scheduler.get().scheduleDeferred(() -> getPicker().close());
     }
 
     /**
      * Programmatically open the date picker component
      */
+    @Override
     public void open() {
         Scheduler.get().scheduleDeferred(() -> getPicker().open());
     }
 
+    @Override
     public boolean isOpen() {
         return Boolean.parseBoolean(getPicker().get("open").toString());
     }

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialDialog.java

@@ -77,7 +77,8 @@
  */
 // @formatter:on
 public class MaterialDialog extends MaterialWidget implements HasType<DialogType>, HasInOutDurationTransition,
-        HasDismissible, HasCloseHandlers<MaterialDialog>, HasOpenHandlers<MaterialDialog>, HasFullscreen, HasOverlayStyle {
+        HasDismissible, HasCloseHandlers<MaterialDialog>, HasOpenHandlers<MaterialDialog>, HasFullscreen, HasOverlayStyle,
+        HasOpenClose {
 
     private JsModalOptions options = new JsModalOptions();
 
@@ -232,6 +233,7 @@ public boolean isFullscreen() {
      *
      * @throws IllegalStateException If the MaterialDialog is not added to the document
      */
+    @Override
     public void open() {
         open(true);
     }
@@ -296,6 +298,7 @@ protected void onNativeClose(boolean autoClosed, boolean fireEvent) {
      * are not using UiBinder. See {@link #open()}.
      * </p>
      */
+    @Override
     public void close() {
         close(false);
     }
@@ -337,6 +340,7 @@ protected void close(Element e, boolean autoClosed, boolean fireEvent) {
         }
     }
 
+    @Override
     public boolean isOpen() {
         return open;
     }

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialFAB.java

@@ -23,6 +23,7 @@
 import com.google.gwt.event.logical.shared.*;
 import com.google.gwt.event.shared.HandlerRegistration;
 import gwt.material.design.client.base.HasAxis;
+import gwt.material.design.client.base.HasOpenClose;
 import gwt.material.design.client.base.HasType;
 import gwt.material.design.client.base.MaterialWidget;
 import gwt.material.design.client.base.mixin.CssNameMixin;
@@ -61,7 +62,7 @@
  */
 //@formatter:on
 public class MaterialFAB extends MaterialWidget implements HasType<FABType>, HasAxis, HasCloseHandlers<MaterialFAB>,
-        HasOpenHandlers<MaterialFAB> {
+        HasOpenHandlers<MaterialFAB>, HasOpenClose {
 
     private CssTypeMixin<FABType, MaterialFAB> typeMixin;
     private CssNameMixin<MaterialFAB, Axis> axisMixin;
@@ -93,6 +94,7 @@ protected void onLoad() {
     /**
      * Open the FAB programmatically
      */
+    @Override
     public void open() {
         open(true);
     }
@@ -112,6 +114,7 @@ public void open(boolean fireEvent) {
     /**
      * Close the FAB programmatically
      */
+    @Override
     public void close() {
         close(true);
     }
@@ -128,6 +131,11 @@ public void close(boolean fireEvent) {
         $(getElement()).closeFAB();
     }
 
+    @Override
+    public boolean isOpen() {
+        return getElement().hasClassName(CssName.ACTIVE);
+    }
+
     @Override
     public void setType(FABType type) {
         getTypeMixin().setType(type);
@@ -148,10 +156,6 @@ public Axis getAxis() {
         return getAxisMixin().getCssName();
     }
 
-    public boolean isOpen() {
-        return getElement().hasClassName(CssName.ACTIVE);
-    }
-
     @Override
     public HandlerRegistration addCloseHandler(CloseHandler<MaterialFAB> handler) {
         return addHandler(handler, CloseEvent.getType());

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialListValueBox.java

@@ -958,7 +958,7 @@ public void setKeyFactory(KeyFactory<T, String> keyFactory) {
     @Override
     public void setReadOnly(boolean value) {
         getReadOnlyMixin().setReadOnly(value);
-        if (!value) {
+        if (!value && isAttached()) {
             $(listBox.getElement()).material_select("destroy");
             $(listBox.getElement()).material_select();
         }

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialSearch.java

@@ -27,6 +27,7 @@
 import com.google.gwt.event.shared.HandlerRegistration;
 import com.google.gwt.user.client.ui.TextBox;
 import gwt.material.design.client.base.HasActive;
+import gwt.material.design.client.base.HasOpenClose;
 import gwt.material.design.client.base.HasSearchHandlers;
 import gwt.material.design.client.base.SearchObject;
 import gwt.material.design.client.constants.*;
@@ -75,7 +76,7 @@
  */
 //@formatter:on
 public class MaterialSearch extends MaterialValueBox<String> implements HasOpenHandlers<String>, HasCloseHandlers<String>,
-        HasActive, HasSearchHandlers {
+        HasActive, HasSearchHandlers, HasOpenClose {
 
     private Label label = new Label();
     private MaterialIcon iconSearch = new MaterialIcon(IconType.SEARCH);
@@ -255,16 +256,23 @@ protected void onUnload() {
     /**
      * Programmatically open the search input field component
      */
+    @Override
     public void open() {
         setActive(true);
         Scheduler.get().scheduleDeferred(() -> $(valueBoxBase.getElement()).focus());
         OpenEvent.fire(MaterialSearch.this, getText());
     }
 
+    @Override
     public void close() {
         close(true);
     }
 
+    @Override
+    public boolean isOpen() {
+        return isActive();
+    }
+
     public void close(boolean fireEvents) {
         setActive(false);
         if (fireEvents) {

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>com.github.gwtmaterialdesign</groupId>
     <artifactId>gwt-material-parent</artifactId>
-    <version>2.4.0-SNAPSHOT</version>
+    <version>2.4.0</version>
     <packaging>pom</packaging>
     <modules>
         <module>gwt-material</module>
@@ -69,7 +69,7 @@
         <connection>scm:git:[email protected]:GwtMaterialDesign/gwt-material.git</connection>
         <developerConnection>scm:git:[email protected]:GwtMaterialDesign/gwt-material.git</developerConnection>
         <url>http://github.com/GwtMaterialDesign/gwt-material</url>
-        <tag>v2.4.0-SNAPSHOT</tag>
+        <tag>v2.4.0</tag>
     </scm>
 
     <licenses>