build(deps): bump several gems#854
Conversation
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Summary of ChangesHello @kostyanf14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive update of the project's Ruby gem dependencies, ensuring that the application leverages the most recent features, bug fixes, and security enhancements from its underlying libraries. It also integrates a new gem, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several gem dependencies. While most of these are minor or patch updates, there are a few major version bumps that could introduce breaking changes. I've added comments on Gemfile.lock to highlight these specific gems: connection_pool, minitest, octokit, public_suffix, and rbs. It's crucial to thoroughly test the application after these updates to ensure everything still works as expected.
There was a problem hiding this comment.
Pull request overview
This PR updates several Ruby dependencies and regenerates their corresponding Sorbet RBI type definitions to match the new gem versions.
Changes:
- Bump multiple gem versions in
Gemfile.lock(e.g.,activesupport,addressable,aws-sdk-*,faraday,octokit,json,concurrent-ruby,unicode-emoji,uri, etc.). - Regenerate Sorbet RBI files for the updated gems, including structural updates (e.g., moving shared APIs to core gems, adding new APIs from newer versions, updating source references).
- Add new RBI stubs for newly introduced or newly-detected runtime dependencies (
require-hooks,connection_pool,minitest,i18n, and a smallactivesupportextension).
Reviewed changes
Copilot reviewed 13 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Gemfile.lock | Updates a set of runtime dependencies to newer versions (e.g., activesupport 8.1.2, addressable 2.8.8, aws-sdk-core 3.241.4, faraday 2.14.0, octokit 10.0.0, json 2.18.0, concurrent-ruby 1.3.6, public_suffix 7.0.2, unicode-emoji 4.2.0, uri 1.1.1, etc.). |
| sorbet/rbi/gems/uri@1.1.1.rbi | Updates source line annotations and references within URI and MailTo RBI definitions to align with the newer uri gem/stdlib version. |
| sorbet/rbi/gems/unicode-emoji@4.2.0.rbi | Updates constants’ source references and adds the new Unicode::Emoji::UNICODE_VERSION constant to match the new emoji data. |
| sorbet/rbi/gems/thor@1.5.0.rbi | Regenerates Thor RBIs for 1.5.0, adding new APIs (e.g., Thor#tree, Thor::Actions injection helpers, several new helpers on Thor::Shell::Basic, Thor::Shell::Color, and tree mappings) and updating source locations. |
| sorbet/rbi/gems/sawyer@0.9.3.rbi | Adjusts several method source references and method owners to match sawyer 0.9.3 (e.g., Relation#href, Relation::Map#to_h, Resource#dig/#fetch, serializer dump/load). |
| sorbet/rbi/gems/require-hooks@0.2.3.rbi | New RBI describing the RequireHooks API, its Context class, and the RequireHooks::LoadIseq extension on RubyVM::InstructionSequence. |
| sorbet/rbi/gems/public_suffix@7.0.2.rbi | Updates documentation comments, parameter ordering, and struct accessor annotations (e.g., Rule::Entry) and adjacency details to match public_suffix 7.0.2, with no functional type signature regressions observed. |
| sorbet/rbi/gems/parser@3.3.10.1.rbi | Syncs RBIs with parser 3.3.10.1, primarily updating Processor callback source references and parameter docs, plus a few new or moved helper methods (eql?, more precise param ordering) without changing core signatures. |
| sorbet/rbi/gems/minitest@6.0.1.rbi | Adds an empty, documented RBI stub for minitest 6.0.1 to control loading via Tapioca, without introducing specific API types. |
| sorbet/rbi/gems/json@2.18.0.rbi | Refreshes the JSON module and related classes (JSON::Coder, JSON::Ext::*, JSON::Fragment, etc.) to 2.18.0, adding new default options helpers and updating docs and source lines; method signatures remain compatible. |
| sorbet/rbi/gems/i18n@1.14.8.rbi | Adds an empty RBI stub for i18n 1.14.8 (no API surface modeled, used only for Tapioca require control). |
| sorbet/rbi/gems/faraday-net_http@3.4.2.rbi | Simplifies the adapter RBI to only define Faraday::Adapter::NetHttp, removing duplicated core Faraday APIs that are now correctly defined in faraday@2.14.0.rbi. |
| sorbet/rbi/gems/connection_pool@3.0.2.rbi | Adds an empty RBI stub for connection_pool 3.0.2. |
| sorbet/rbi/gems/concurrent-ruby@1.3.6.rbi | Updates RBIs for concurrent-ruby, adding Concurrent::Collection::MapImplementation, MriMapBackend, NonConcurrentMapBackend, TimeoutQueue, a full Concurrent::Map API, and aligning docs and param ordering across executors and concerns. |
| sorbet/rbi/gems/aws-partitions@1.1210.0.rbi | Narrows the RBI to just module Aws for this gem, removing incorrectly inlined Aws class methods that now live in aws-sdk-core@3.241.4.rbi. |
| sorbet/rbi/gems/addressable@2.8.8.rbi | Refreshes the Addressable RBIs, especially Addressable::IDNA, template APIs, and URI helpers, to align with addressable 2.8.8 (new internal helpers, updated constants, corrected docs, but consistent signatures). |
| sorbet/rbi/gems/activesupport@8.1.2.rbi | Adds a small RBI to reopen NameError and include ErrorHighlight::CoreExt and DidYouMean::Correctable, matching ActiveSupport’s behavior for richer error messages. |
Across all reviewed changes, the RBIs appear to be consistent with their corresponding gem versions, moved shared APIs are now correctly associated with the core gems (e.g., faraday, aws-sdk-core), and there are no obvious type signature regressions or structural issues.
Files not reviewed (1)
- sorbet/rbi/gems/require-hooks@0.2.3.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.