Skip to content

Update instructions to get tag from Harbor#38

Open
HerbertHilhorst wants to merge 4 commits intomainfrom
HerbertHilhorst-patch-1
Open

Update instructions to get tag from Harbor#38
HerbertHilhorst wants to merge 4 commits intomainfrom
HerbertHilhorst-patch-1

Conversation

@HerbertHilhorst
Copy link

No description provided.

dx.properties Outdated
# And for each of the entries, update to use the tag of your selected release
# E.g. for CF233: DX_DOCKER_IMAGE_CONTENT_COMPOSER=hclcr.io/dx-compose/content-composer:v1.46.0_20260206-1427

DX_DOCKER_IMAGE_CONTENT_COMPOSER=hclcr.io/dx/content-composer:v1.29.0_20231114-2121
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect! By shipping this git repository the dx.properties need to be mentioned with empty values! The values then automatically will be set as soon as the load.bat or load.sh script is called. There is no need to manually set this properties at all. instead of that I would suggest to create a new script to this repository to get all these images from habor and then to set this properties then also automatically in that script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerbertHilhorst I created a new PR to start adding that feature, because I noticed that your pull request was based on an older branch level. So I would suggest to follow up with the discussion then on #40

@reinheimer1
Copy link
Contributor

I am going to work on a script to load images from habor that then also automatically set these properties.

@reinheimer1 reinheimer1 self-assigned this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants