Skip to content

Add ktlint config and CI lint/test workflows#12

Merged
hdcodedev merged 8 commits intomainfrom
feat/ktlint-ci-test-flow
Feb 20, 2026
Merged

Add ktlint config and CI lint/test workflows#12
hdcodedev merged 8 commits intomainfrom
feat/ktlint-ci-test-flow

Conversation

@hdcodedev
Copy link
Member

@hdcodedev hdcodedev commented Feb 20, 2026

What

  • add ktlint setup and shared .editorconfig
  • add PR lint and test workflows with code-change gating
  • add aggregate Gradle test tasks for CI
  • include current gesture/recording related updates in this branch

Validation

  • ran ktlint format/check tasks
  • dry-ran new CI test tasks

@kilo-code-bot
Copy link
Contributor

kilo-code-bot bot commented Feb 20, 2026

Code Review Summary

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
scripts/ci-has-code-changes.sh N/A scripts/ directory is included in CODE_PATH_PATTERN, so changes to ci-has-code-changes.sh itself trigger CI — this creates a bootstrapping risk where a broken script can't be tested before it gates CI
lib/recorder-gradle-plugin/src/main/kotlin/io/github/hdcodedev/composegif/plugin/ComposeGifRecorderPlugin.kt N/A Regex with DOT_MATCHES_ALL may match across scenario boundaries in parseScenarioNames
scripts/ci-test-summary.sh 109 line_text() is defined but never called — dead code

SUGGESTION

File Line Issue
lib/recorder-ksp/src/main/kotlin/io/github/hdcodedev/composegif/ksp/InteractionGestureExpander.kt 109 target = "LEFT" or "RIGHT" is silently ignored for horizontal swipes (falls through to 0.5f); consider logging a warning or documenting this intentional behavior
Files Reviewed (9 files)
  • .editorconfig - 0 issues
  • .github/workflows/lint.yml - 0 issues
  • .github/workflows/pr-test-summary-comment.yml - 0 issues
  • .github/workflows/test.yml - 0 issues
  • lib/recorder-ksp/src/main/kotlin/io/github/hdcodedev/composegif/ksp/InteractionGestureExpander.kt - 1 issue
  • lib/recorder-ksp/src/main/kotlin/io/github/hdcodedev/composegif/ksp/RecordGifSymbolProcessorProvider.kt - 0 issues
  • lib/recorder-ksp/src/test/kotlin/io/github/hdcodedev/composegif/ksp/InteractionGestureExpanderTest.kt - 0 issues
  • scripts/ci-has-code-changes.sh - 1 issue
  • scripts/ci-test-summary.sh - 1 issue
  • settings.gradle.kts - 0 issues

Fix these issues in Kilo Cloud

hdcodedev and others added 3 commits February 20, 2026 02:02
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
@hdcodedev hdcodedev merged commit 44f25fb into main Feb 20, 2026
2 checks passed
@hdcodedev hdcodedev deleted the feat/ktlint-ci-test-flow branch February 20, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant