-
-
Notifications
You must be signed in to change notification settings - Fork 22
fixed LZ4 plugin #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
captainkirk99
wants to merge
22
commits into
HDFGroup:master
Choose a base branch
from
captainkirk99:e1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fixed LZ4 plugin #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to get a CI running before submitting this PR (see #201). |
byrnHDF
approved these changes
Sep 14, 2025
OK, approve my workflow runs and we'll see how the CI likes these changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Filter - LZ4
Priority - 1. High 🔼
These are important issues that should be resolved in the next release
Type - Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the LZ4 plugin. Fixes #200
Important
Fix and optimize LZ4 plugin by removing
static
keyword, initializingblockSize
, usingLZ4_compress_fast
, and commenting out debug prints inH5Z_filter_lz4
.static
keyword fromH5Z_filter_lz4
declaration and definition inH5Zlz4.c
.blockSize
toDEFAULT_BLOCK_SIZE
in forward filter path.LZ4_compress_fast
instead ofLZ4_compress_default
inH5Z_filter_lz4
.printf
statements inH5Z_filter_lz4
for decompression size mismatch and block size information.This description was created by
for bcb40e0. You can customize this summary. It will automatically update as commits are pushed.