Fixes Mac Info and settings... menu options. #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtnfld
requested review from
byrnHDF,
jhendersonHDF and
lrknox
as code owners
| userOptionDialog.getShell().isDisposed()); | ||
|
|
||
| if (needsCreation) { | ||
| log.debug("Creating User Options dialog (first open or after disposal) - this takes ~2 seconds..."); |
Collaborator
There was a problem hiding this comment.
It really doesn't seem appropriate to mention anything about timing even in logging, especially because opening this dialog is near-instant for me on Linux.
| userOptionDialog.create(); | ||
| } | ||
| else { | ||
| log.debug("Reusing cached User Options dialog (instant open)"); |
Author
There was a problem hiding this comment.
I think I'm going to abandon trying to work around the delay on the mac, nothing seems to work. It just pushes the delay somewhere else.
Collaborator
There was a problem hiding this comment.
Some initial profiling should be done to see where time is being spent. There's a lot of logic that can probably be avoided, especially if we separate options into categories better.
Removed OS-specific guard - No more ViewProperties.isMacOS() check Removed unnecessary asyncExec Removed redundant checks - No need for shell.isDisposed() checks that aren't used elsewhere Cleaned up variables - Removed unused display variable Platform-neutral naming - Method and log messages now use "system menu" terminology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated fix from #454
Important
Fixes macOS menu handling in
HDFView.javaand centralizes macOS detection inViewProperties.java.setupMacOSMenuHandlers()inHDFView.javato handle macOS-specific "About" and "Preferences" menu items.openUserOptionsDialog()inHDFView.java.isMacOS()method inViewProperties.javafor centralized macOS detection.ViewProperties.isMacOS()inDefaultScalarDSTableView.javaandHDFView.java..github/CODEOWNERSto replace@byrnHDFwith@mattjala.This description was created by
for e6b15a5. You can customize this summary. It will automatically update as commits are pushed.