Conversation
|
Botocore and the replacement for unixsocket have an unavoidable dependency conflict for Python 3.9. Options for resolving this are to drop support for Python 3.9, freeze requests/urllib/requests-unixsocket at their current version, or replace requests-unixsocket with something else |
|
I'd vote to drop support for Unix Sockets. Originally I was thinking that this might be a performance enhancement for clients and servers on the same host, but it's marginal if anything. Also, I think there can be problems when two clients are using the same socket connection. If we go this way, the ruanll.sh script should change the --no-docker option to use TCP rather than sockets. |
|
Actually we use unix sockets in hsds_app.py, and I prefer not to update the code to use tcp sockets. |
jreadey
left a comment
There was a problem hiding this comment.
Let's go with this. I'll submit a PR to remove Python 3.9 support
The original package is incompatible with requests 2.32.0+.
Important
Replace deprecated
requests-unixsocketwithrequests-unixsocket2and update related dependencies for compatibility withrequests2.32.0+.requests-unixsocketwithrequests-unixsocket2inPipfile,pyproject.toml, andrequirements.txt.requestsversion constraint to<=2.32.4inPipfile,pyproject.toml, andrequirements.txt.urllib3version constraint to>=2.4.0,<3.0inPipfile,pyproject.toml, andrequirements.txt.aiobotocoreversion constraint to>=2.13.0inPipfile,pyproject.toml, andrequirements.txt.requestsversion in.github/workflows/python-package.yml.This description was created by
for c071fa4. You can customize this summary. It will automatically update as commits are pushed.