Add support for yoda-H5 #7
Conversation
* Also upgrade actions/checkout and actions/setup-python.
* '%' encoded as '%2525' instead of '%25', so replace in URL.
* Remove explanation of Click problem with Python 3.6. * Install virtual environment in subdirectory 'venv'. * Correct typo: 'four' to 'six' when counting non-JSON file formats.
* Necessary to avoid "429 Client Error: TOO MANY REQUESTS" error.
* Try to avoid "too many 429 error responses".
* Use fewer test cases to avoid 429 error responses, keeping coverage.
* Avoid 429 responses from running tests for multiple Python versions. * Check installation and "hepdata-cli --help" for all Python versions.
* Problem w/ Python 3.13 & Coveralls (TheKevJames/coveralls-python#549).
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the yoda-H5 file format to the hepdata command line interface, following up on related work in the hepdata-converter repository. The changes enable users to download data in the .yoda.h5 format through both the API and CLI.
- Include
.yoda.h5in the list of supported file formats - Update documentation to reflect the new format availability
- Add test cases to verify yoda-H5 functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| hepdata_cli/api.py | Adds yoda.h5 to ALLOWED_FORMATS and updates documentation |
| hepdata_cli/cli.py | Updates CLI help text to reference ALLOWED_FORMATS dynamically |
| tests/test_download.py | Adds test cases for yoda-H5 format downloads |
| tests/test_search.py | Reorganizes test parameters for API and CLI testing |
| README.md | Updates documentation to include yoda.h5 format |
| setup.py | Bumps minimum Python version requirement to 3.7 |
| hepdata_cli/version.py | Updates version to 0.2.3 |
| .github/workflows/ci.yml | Updates CI configuration for newer Python versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@codecov-ai-reviewer review |
This comment has been minimized.
This comment has been minimized.
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
* Comment to investigate double URL encoding (new issue HEPData#8).
|
@mhabedan : I've merged this PR and tagged a new release v0.2.3 (PyPI). Thanks for all your contributions to support the The table name "95% CL upper limit on XSEC times BF" you added to the tests uncovered a bug due to double URL encoding of the |
|
Thanks @GraemeWatt for pushing this over the finish line and apologies it turned out to be so much more cumbersome than I anticipated. Really appreciate your help on this! It works beautifully now. |
2 participants
As a follow-up to HEPData/hepdata-converter#64, this PR adds yoda-H5 support for the hepdata command line interface.
Namely the changes are
.yoda.h5in supported file formats.Tested locally on commit f923a755 from hepdata-converter.
Requires HEPData/hepdata#884.