Skip to content

Fix docs: remove non-existent Parser/set_parser references#53

Merged
HEROgold merged 2 commits intonested-levelsfrom
copilot/sub-pr-52
Mar 2, 2026
Merged

Fix docs: remove non-existent Parser/set_parser references#53
HEROgold merged 2 commits intonested-levelsfrom
copilot/sub-pr-52

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

The Required Initialization section in copilot-instructions.md referenced a Parser facade class and Config.set_parser() method that don't exist in the codebase. The actual implementation uses IniParser/MsgspecParser with a private _set_parser().

Changes

  • Removed "Option 2" — dropped the fabricated Parser class and Config.set_parser() usage block entirely; _set_parser is private and not a supported public API worth documenting
  • Removed .env from auto-detection examplePath(".env").suffix == "" falls through to the unsupported-extension error in _detect_parser; auto-detection via set_file() does not work for .env files
  • Clarified .env format entry — noted in "Supported File Formats" that EnvParser is not auto-detected by set_file()

The initialization section now only documents the actual public API:

Config.set_file(Path("config.ini"))   # Uses IniParser
Config.set_file(Path("config.json"))  # Uses MsgspecParser
Config.set_file(Path("config.yaml"))  # Uses MsgspecParser
Config.set_file(Path("config.toml"))  # Uses MsgspecParser

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on nested configuration support Fix docs: remove non-existent Parser/set_parser references Mar 2, 2026
@HEROgold HEROgold marked this pull request as ready for review March 2, 2026 17:57
Copilot AI review requested due to automatic review settings March 2, 2026 17:57
@HEROgold HEROgold merged commit bfab9a4 into nested-levels Mar 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Copilot guidance to accurately reflect confkit’s public initialization API and parser auto-detection behavior, removing references to non-existent classes/methods.

Changes:

  • Removed documentation of a non-existent Parser facade and Config.set_parser() API.
  • Updated initialization example to only show supported Config.set_file(...) auto-detection cases.
  • Clarified that .env uses EnvParser but is not auto-detected by set_file().

HEROgold added a commit that referenced this pull request Mar 2, 2026
* Add support for nested configuration

* Update docs/examples/custom_data_type.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix docs: remove non-existent `Parser`/`set_parser` references (#53)

* Initial plan

* Fix documentation: remove non-existent Parser/set_parser references

Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>

* mark as deprecation instead of private method

* Raise ConfigPathConflictError when trying to path through a scalar.

* fix ruff issue

* ignore line len on deprecation warning

* ruff fixes

* add missing .env parse detection

* Separate built-in parsers from msgspec optional dependency; fix MsgspecParser type handling and conflict detection (#54)

* Initial plan

* Move built-in parsers to confkit.parsers, fix type handling and conflict detection

Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>

* fix docstr

* fix ruff

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@HEROgold HEROgold deleted the copilot/sub-pr-52 branch March 2, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants