Fix docs: remove non-existent Parser/set_parser references#53
Merged
HEROgold merged 2 commits intonested-levelsfrom Mar 2, 2026
Merged
Fix docs: remove non-existent Parser/set_parser references#53HEROgold merged 2 commits intonested-levelsfrom
Parser/set_parser references#53HEROgold merged 2 commits intonested-levelsfrom
Conversation
Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on nested configuration support
Fix docs: remove non-existent Mar 2, 2026
Parser/set_parser references
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Copilot guidance to accurately reflect confkit’s public initialization API and parser auto-detection behavior, removing references to non-existent classes/methods.
Changes:
- Removed documentation of a non-existent
Parserfacade andConfig.set_parser()API. - Updated initialization example to only show supported
Config.set_file(...)auto-detection cases. - Clarified that
.envusesEnvParserbut is not auto-detected byset_file().
HEROgold
added a commit
that referenced
this pull request
Mar 2, 2026
* Add support for nested configuration * Update docs/examples/custom_data_type.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix docs: remove non-existent `Parser`/`set_parser` references (#53) * Initial plan * Fix documentation: remove non-existent Parser/set_parser references Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com> * mark as deprecation instead of private method * Raise ConfigPathConflictError when trying to path through a scalar. * fix ruff issue * ignore line len on deprecation warning * ruff fixes * add missing .env parse detection * Separate built-in parsers from msgspec optional dependency; fix MsgspecParser type handling and conflict detection (#54) * Initial plan * Move built-in parsers to confkit.parsers, fix type handling and conflict detection Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: HEROgold <21345384+HEROgold@users.noreply.github.com> * fix docstr * fix ruff --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Required Initializationsection incopilot-instructions.mdreferenced aParserfacade class andConfig.set_parser()method that don't exist in the codebase. The actual implementation usesIniParser/MsgspecParserwith a private_set_parser().Changes
Parserclass andConfig.set_parser()usage block entirely;_set_parseris private and not a supported public API worth documenting.envfrom auto-detection example —Path(".env").suffix == ""falls through to the unsupported-extension error in_detect_parser; auto-detection viaset_file()does not work for.envfiles.envformat entry — noted in "Supported File Formats" thatEnvParseris not auto-detected byset_file()The initialization section now only documents the actual public API:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.