Skip to content

Fiddle instrument#736

Merged
psavery merged 5 commits intoHEXRD:masterfrom
bnmajor:fiddle-instrument
Mar 19, 2025
Merged

Fiddle instrument#736
psavery merged 5 commits intoHEXRD:masterfrom
bnmajor:fiddle-instrument

Conversation

@bnmajor
Copy link
Copy Markdown
Collaborator

@bnmajor bnmajor commented Dec 16, 2024

@saransh13 this is the default config file that needs your approval

@bnmajor bnmajor requested review from psavery and saransh13 December 16, 2024 15:13
@bnmajor bnmajor mentioned this pull request Dec 17, 2024
17 tasks
Brianna Major and others added 5 commits February 28, 2025 14:38
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
At this point its still unclear why this is needed since the engineering
drawings state that the values are not scaled. This does fix the issue though,
and the template appears correct with this adjustment.

Signed-off-by: Brianna Major <brianna.major@taloid.khq.kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
Accounts for the cropped image plate after using the import tool.

Signed-off-by: Brianna Major <brianna.major@kitware.com>
@bnmajor bnmajor removed the request for review from saransh13 February 28, 2025 22:14
Copy link
Copy Markdown
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@psavery psavery merged commit a108a6e into HEXRD:master Mar 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants