Skip to content

fixes nan error in fast powder calibration#754

Merged
saransh13 merged 2 commits intomasterfrom
fast-powder-fix
Jan 31, 2025
Merged

fixes nan error in fast powder calibration#754
saransh13 merged 2 commits intomasterfrom
fast-powder-fix

Conversation

@saransh13
Copy link
Copy Markdown
Member

ValueError: cannot convert float NaN to integer error was generated when running fast powder calibration on some configurations. Culprit was found to be some invalid pixels when searching for peaks. Masking out those peaks before searching.

@saransh13 saransh13 requested a review from psavery January 31, 2025 19:04
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.61%. Comparing base (dfbeb97) to head (ffa8ace).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/instrument/hedm_instrument.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   39.62%   39.61%   -0.01%     
==========================================
  Files         140      140              
  Lines       22696    22701       +5     
==========================================
  Hits         8994     8994              
- Misses      13702    13707       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saransh13 saransh13 merged commit 047ce00 into master Jan 31, 2025
6 of 7 checks passed
@ZackAttack614 ZackAttack614 deleted the fast-powder-fix branch February 6, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants