Closed
Conversation
psavery
reviewed
Feb 11, 2025
| @classmethod | ||
| def from_grains_out(cls, fname): | ||
| """Read hexrd grains output file""" | ||
| return cls.from_array(np.loadtxt(fname)) |
Collaborator
There was a problem hiding this comment.
Nice, Don! This class is looking like it is becoming very useful 🙂
psavery
reviewed
Feb 11, 2025
| @pytest.fixture | ||
| def quats90(): | ||
| c45, s45 = np.cos(np.pi / 4), np.sin(np.pi /4) | ||
| return [[c45, s45, 0, 0], [c45, 0, s45, 0], [c45, 0, 0, s45]] |
Collaborator
There was a problem hiding this comment.
Constants could also just be global variables like QUATS_90. pytest fixtures often use other things like environment variables or data on disk to make them. But it doesn't hurt to do it this way, and you can keep it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some new features to the GrainData class, including saving/reading grains.out files, quaternions attribute, strain attribute and a
selectmethod. This also adds user documentation in the docs section.