Skip to content

some fixes for simulating powder diffraction pattern on an instrument.#773

Merged
psavery merged 1 commit intomasterfrom
simulated-powder-diffraction-fix
Apr 9, 2025
Merged

some fixes for simulating powder diffraction pattern on an instrument.#773
psavery merged 1 commit intomasterfrom
simulated-powder-diffraction-fix

Conversation

@saransh13
Copy link
Copy Markdown
Member

Spotted two errors:

  1. the size of stacking fault shifts and stacking fault broadening not the same
  2. the angularpixelsize has a zeros which was taken as the angular resolution. masking out zeros in those values.

@saransh13 saransh13 requested a review from psavery February 25, 2025 22:42
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.13%. Comparing base (e8257a7) to head (cbe0861).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   46.12%   46.13%   +0.01%     
==========================================
  Files         142      142              
  Lines       22822    22828       +6     
==========================================
+ Hits        10526    10532       +6     
  Misses      12296    12296              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psavery psavery merged commit 8dcb290 into master Apr 9, 2025
7 checks passed
@ZackAttack614 ZackAttack614 deleted the simulated-powder-diffraction-fix branch February 6, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants