Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 69.78% 69.86% +0.07%
==========================================
Files 146 146
Lines 22161 22193 +32
==========================================
+ Hits 15466 15506 +40
+ Misses 6695 6687 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psavery
reviewed
Feb 2, 2026
Collaborator
psavery
left a comment
There was a problem hiding this comment.
Haven't had a chance to review everything yet. But here are some comments so far. I'll try to review more soon!
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
psavery
reviewed
Feb 3, 2026
Collaborator
|
Please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is the first of many which will add docstrings and typing to the HEXRD library.
Affected Workflows
No workflows are affected by this PR.
Documentation Changes
This PR adds explicit documentation for functions in a few places, including argument types and descriptors. It also adds static type identifiers to a number of variables, parameters, and return types for clarity.