Skip to content

Reconcilliation#895

Merged
ZackAttack614 merged 8 commits intomasterfrom
reconcilliation
Mar 25, 2026
Merged

Reconcilliation#895
ZackAttack614 merged 8 commits intomasterfrom
reconcilliation

Conversation

@ZackAttack614
Copy link
Copy Markdown
Collaborator

Overview

This PR removes duplicate files and functions between hedm and core. No functionality is removed.

Affected Workflows

No workflows should be affected, unless there are folks who have begun using the hedm version in the last few months, which is unlikely.

Documentation Changes

No documentation changes are required for this PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 78.78788% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.07%. Comparing base (ee7fa00) to head (33b776b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/hedm/instrument/generate_eta_omega_maps.py 75.86% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   70.90%   71.07%   +0.17%     
==========================================
  Files         143      142       -1     
  Lines       22076    21865     -211     
==========================================
- Hits        15652    15541     -111     
+ Misses       6424     6324     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZackAttack614 ZackAttack614 merged commit 177e3be into master Mar 25, 2026
10 checks passed
@ZackAttack614 ZackAttack614 deleted the reconcilliation branch March 25, 2026 14:52
psavery added a commit to HEXRD/hexrdgui that referenced this pull request Mar 25, 2026
It was moved in HEXRD/hexrd#895 to the hedm workflow path.

Update it here so it will work properly.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants