Conversation
Before, if the `tThWidth` was set to `None`, which is a valid setting, saving the material and reloading it would reset it to the default value, rather than restoring the value of `None`. This PR fixes the bug so that `None` is properly saved and restored, as it should be. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 71.09% 71.10%
=======================================
Files 142 142
Lines 21856 21855 -1
=======================================
Hits 15539 15539
+ Misses 6317 6316 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Before, if the
tThWidthwas set toNone, which is a valid setting, saving the material and reloading it would reset it to the default value, rather than restoring the value ofNone.This PR fixes the bug so that
Noneis properly saved and restored, as it should be.Affected Workflows
All workflows, but it probably doesn't affect most users (only a select few would set it to
None).Documentation Changes
None