Skip to content

Simulate laue pattern#911

Open
ZackAttack614 wants to merge 3 commits intomasterfrom
simulate-laue-pattern
Open

Simulate laue pattern#911
ZackAttack614 wants to merge 3 commits intomasterfrom
simulate-laue-pattern

Conversation

@ZackAttack614
Copy link
Copy Markdown
Collaborator

Overview

The simulate_laue_pattern functions for Detector and HEDMInstrument have been moved into the laue workflow, from the core directory. This is a necessary step in ensuring that the new architecture keeps workflow-specific functions and classes in the correct workflow directories.

  • hexrd.core.instrument.detector.Detector.simulate_laue_pattern has been removed from the context of a class method, and made into a standalone function in the laue workflow here: hexrd.laue.simulate.simulate_laue_pattern_on_panel
  • hexrd.core.instrument.hedm_instrument.HEDMInstrument.simulate_laue_pattern has been removed from the context of a class method, and made into a standalone function in the laue workflow here: hexrd.laue.simulate.simulate_laue_pattern_on_instrument

Affected Workflows

This change affects users of the Laue workflow simulating laue patterns.

Documentation Changes

  • Migration instructions must be written in the library wiki before this PR can be accepted.

@ZackAttack614 ZackAttack614 requested a review from psavery March 26, 2026 21:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.26%. Comparing base (177e3be) to head (c3cf46b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/laue/fitting/calibration/laue.py 33.33% 2 Missing ⚠️
hexrd/laue/simulation.py 98.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   71.09%   71.26%   +0.17%     
==========================================
  Files         142      142              
  Lines       21856    21792      -64     
==========================================
- Hits        15539    15531       -8     
+ Misses       6317     6261      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants