Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
+ Coverage 71.09% 71.26% +0.17%
==========================================
Files 142 142
Lines 21856 21792 -64
==========================================
- Hits 15539 15531 -8
+ Misses 6317 6261 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psavery
reviewed
Mar 27, 2026
psavery
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
simulate_laue_patternfunctions forDetectorandHEDMInstrumenthave been moved into the laue workflow, from the core directory. This is a necessary step in ensuring that the new architecture keeps workflow-specific functions and classes in the correct workflow directories.hexrd.core.instrument.detector.Detector.simulate_laue_patternhas been removed from the context of a class method, and made into a standalone function in thelaueworkflow here:hexrd.laue.simulate.simulate_laue_pattern_on_panelhexrd.core.instrument.hedm_instrument.HEDMInstrument.simulate_laue_patternhas been removed from the context of a class method, and made into a standalone function in thelaueworkflow here:hexrd.laue.simulate.simulate_laue_pattern_on_instrumentAffected Workflows
This change affects users of the Laue workflow simulating laue patterns.
Documentation Changes