Conversation
psavery
reviewed
Mar 21, 2025
| cancel_workflow = Signal() | ||
|
|
||
| complete_workflow = Signal() | ||
| complete_workflow = Signal(bool) |
Collaborator
There was a problem hiding this comment.
Can you leave a comment above this line as well that indicates what the bool is for?
When the median filter is set immediately after the LLNL import workflow is complete the menu option still needs to be toggled "on" if the filter is applied. Make sure that it is. Signed-off-by: Brianna Major <brianna.major@kitware.com>
bnmajor
force-pushed
the
median-filter-checkbox
branch
from
69e0e50 to
1622569
Compare
psavery
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the median filter is set immediately after the LLNL import workflow is complete the menu option still needs to be toggled "on" if the filter is applied. Make sure that it is.