Fix filter options for absorption correction#1826
Merged
Conversation
psavery
reviewed
Apr 9, 2025
psavery
reviewed
Apr 10, 2025
Comment on lines
19
to
20
| HexrdConfig().update_detector_filter(det) | ||
| filter = HexrdConfig().detector_filter(det) |
Collaborator
There was a problem hiding this comment.
So, if there isn't a filter, we also wouldn't want to add one unless the user clicks "OK", right? I think we shouldn't modify any settings unless the user clicks "OK".
In this case, if the user clicks "Cancel", would there now be a filter present for that detector (even though there wasn't one before)?
Make sure that we manage filter inputs separately for each detector. Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
bnmajor
force-pushed
the
absorption-correction
branch
from
58a372b to
fbdc23e
Compare
Member
Screen.Recording.2025-04-11.at.1.52.04.PM.movI still see the filter material going back to the default one when cycling between detectors. There's also a stray print statement somewhere generating this text |
Signed-off-by: Brianna Major <brianna.major@kitware.com>
saransh13
approved these changes
Apr 17, 2025
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
Ok, LGTM ready to merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that we manage filter inputs separately for each detector.