Fix issues we encountered in matplotlib 3.10#1833
Merged
Conversation
psavery
force-pushed
the
fix-matplotlib-3.10
branch
from
a6c50bb to
a757668
Compare
Collaborator
Author
|
@saransh13 @bnmajor Can either of you review? You will need to upgrade matplotlib on your computer. If we run into more issues, hopefully we can fix them pretty quickly. The changes matplotlib make did result in errors in numerous places. |
psavery
force-pushed
the
fix-matplotlib-3.10
branch
from
a757668 to
d24473d
Compare
It's not safe to remove artists the old way, because they may raise an exception if the figure they were in was cleared. Instead, we have to do it this way and just ignore any errors that occur. It would be nice if we figured out a cleaner way at some point. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
fix-matplotlib-3.10
branch
from
4ca0aa3 to
6d43b6a
Compare
Collaborator
Author
|
This has been revived. I think we are ready to upgrade matplotlib |
saransh13
approved these changes
Dec 12, 2025
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
didn't encounter any issues. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also unpin the matplotlib version as a result.
I did not immediately see any further issues, but if we encounter more in the future, we can hopefully fix them quickly.
Thanks @patquem for the pointer in #1772!
Fixes: #1772