Unpin PySide6 #1834
Merged
Unpin PySide6 #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Due to the failing tests, I guess we still can't unpin it |
Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
unpin-pyside6
branch
from
799d7db to
f6d4a84
Compare
This is necessary for some versions of Python, such as 3.11, starting with Qt 6.8. But it looks like it is no longer a problem for some versions of Python, such as 3.14. So we can potentially try to drop it in the future, after older versions of Python are removed. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
unpin-pyside6
branch
from
5ae6373 to
db6d729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the issues requiring this are fixed...