Conversation
This adds type annotations and fixes mypy errors. There are several places where `Any` is used where it doesn't actually need to be used, and a few places where `# type: ignore` is used as well, but overall, this is a substantial improvement over before, where there was no typing. We can fix some of the minor issues later. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Even though mypy thinks these should be bytes, they actually need to be strings. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
bnmajor
approved these changes
Feb 24, 2026
Collaborator
bnmajor
left a comment
bnmajor
left a comment
There was a problem hiding this comment.
Seems reasonable to me!
psavery
added a commit
that referenced
this pull request
Mar 3, 2026
This fixes an issue introduced in PR #1966 The masks having an empty string as the name meant that they were not saved. We need to allow them to be `None` instead. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds type annotations and fixes mypy errors.
There are several places where
Anyis used where it doesn't actually need to be used, and a few places where# type: ignoreis used as well, but overall, this is a substantial improvement over before, where there was no typing. We can fix some of the minor issues later.