Graphical and Mbc3 Bug Fixes #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPU requires negative values for WX Register when games set WX less than 7. Notable example is Link's Awakening DMG which sets it to 6. Values less than 7 should shift the window off screen to the left not overflow.
1. Rtc was not initializing on MBC3, added make() to struct initialization. 2. window vs background is on a per pixel basis, not per scanline by using the windowX Register. This is viewable with the Pokedex in Pokemon Gold, where the left side of the screen uses background and the right side uses window. Fixed by splitting background and window addresses per scanline, then checking if window is used and if the current pixel >= windowX. If you need a save to see behavior please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes while testing on Pokemon Gold.