fix: complete wave 3 accessibility remediation#5253
Open
Conversation
Remove the remaining Wave 3 accessibility suppressions by fixing link, landmark, and decorative SVG issues across the gated flows. Document the updated baseline for issue #5149 and make the TruffleHog hook worktree-safe so the branch can commit cleanly.
Contributor
There was a problem hiding this comment.
Pull request overview
Completes Wave 3 of the accessibility remediation plan for #5149 by removing remaining Cypress axe suppressions/allowlist entries and adjusting UI markup so key gated flows pass targeted axe rules (link naming, SVG alt handling, and landmark/heading consistency).
Changes:
- Remove the global Cypress
link-namesuppression and burn down the temporary a11y allowlist to zero entries. - Update multiple UI components to provide accessible names for icon-only controls/links and mark decorative SVG icons as
aria-hidden. - Update/expand Wave 3 tracking documentation and refresh the accessibility audit baseline; adjust TruffleHog pre-commit hook behavior.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/agreements/review/ReviewAgreement.jsx | Wrap loading state in App to preserve layout landmarks/headings during route transitions. |
| frontend/src/pages/agreements/details/Agreement.jsx | Wrap loading state in App and use an h1 for consistent page structure during loading. |
| frontend/src/components/UI/NotificationCenter/NotificationCenter.jsx | Replace clickable SVGs with buttons and hide decorative SVGs from the accessibility tree. |
| frontend/src/components/UI/Header/User.jsx | Ensure the profile link has a non-empty accessible name and avoid linking when user.id is missing. |
| frontend/src/components/Portfolios/PortfolioSummaryCards/PortfolioLegend.jsx | Hide decorative legend icons from assistive tech to satisfy svg-img-alt. |
| frontend/src/components/Portfolios/PortfolioHero/HeroDescription.jsx | Hide decorative external-link icon from assistive tech. |
| frontend/src/components/Portfolios/PortfolioFundingByCAN/PortfolioFundingByCAN.jsx | Hide decorative color key icon from assistive tech. |
| frontend/src/components/CANs/CANBudgetLineTable/CANBudgetLineTableRow.jsx | Add explicit accessible naming for agreement links and trim displayed names. |
| frontend/src/components/BudgetLineItems/ChangeIcons/ChangeIcons.jsx | Hide decorative icons/SVGs inside already-labeled buttons. |
| frontend/src/components/BudgetLineItems/BLIStatusSummaryCard/BLIStatusSummaryCard.jsx | Hide decorative status indicator icon from assistive tech. |
| frontend/src/components/BudgetLineItems/AllBudgetLinesTable/AllBLIRow.jsx | Add resilient accessible naming for agreement links and avoid rendering invalid links. |
| frontend/src/components/Agreements/Documents/UploadDocument.jsx | Wrap in App to avoid nested landmarks and preserve layout semantics. |
| frontend/cypress/support/e2e.js | Remove global injectAxe overwrite that disabled link-name outside the regression gate. |
| frontend/cypress/support/a11yAllowlist.js | Clear the temporary allowlist inventory while keeping validation utilities intact. |
| frontend/cypress/e2e/notificationCenter.cy.js | Enable active axe execution for the notification center spec. |
| docs/developers/frontend/accessibility/issue-5149-wave-3.md | Add Wave 3 remediation tracker with status snapshots and progress log. |
| docs/accessibility/github-issue-accessibility-audit.md | Update checklist/progress notes and document Wave 3 direction. |
| docs/accessibility/audit-baseline-2026-02-25.md | Refresh baseline summary and mark addressed findings as fixed. |
| .pre-commit-config.yaml | Change TruffleHog hook to run in filesystem mode for worktree safety. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/components/CANs/CANBudgetLineTable/CANBudgetLineTableRow.jsx
Show resolved
Hide resolved
Use a unique fallback label for CAN agreement links, align the legend unit test with decorative SVG behavior, and narrow the worktree-safe TruffleHog hook to changed files.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fpigeonjr
requested review from
Santi-3rd,
johndeange,
josbell,
rajohnson90 and
weimiao67
as code owners
weimiao67
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Linked Issue