[Issue #8997] SOAP/Proxy: handle HTTPError Privilege issue without logging exception

[jakobpederson]

Summary

Fixes / Work for #8997

Changes proposed

Handled the HTTPError that results when user does not have Privilege to access an application.

Context for reviewers

Previously this was being logged as an exception which was setting off alarms in New Relic. This handles it more gracefully and lessens alarm noise.

Validation steps

[kkrug]

Is this overly broad? Is it possible to hit this HTTPError from something other than a permissions issue?

[jakobpederson]

I think the thinking is we only ever explicitly raise an HTTPError in one place in the SOAP/Proxy. I think in the space between this check and the actual response we won't see any other HTTPError. That being said I think you're right and we could easily raise a custom exception so I'll add that.

[kkrug]

Is this testing the correct log message (i.e. the one you just added, "soap_client_certificate: User did not have permission to access this application")? I think this is testing the inner log message from get_application_zip_response.py.

---

Also, is there actually an assertion here that verifies the AC of "not having the correct permission does not log the exception?" I would think we need something verifies that logging did not occur, something like:
error_records = [r for r in caplog.records if r.levelno >= logging.ERROR and "Unable to process Simpler SOAP proxy response" in r.message] assert len(error_records) == 0

[kkrug]

I think the assert after this is redundant - if the message isn't found within next() it will raise an error and fail the test, though that would be with an unhelpful failure message. You could do a list comprehension with assert len(...) == 1.