[Issue #8926] During application submission, populate fields needed for award rec#9020
Open
[Issue #8926] During application submission, populate fields needed for award rec#9020
Conversation
| return project_title | ||
|
|
||
|
|
||
| REQUESTED_AMOUNT_FORM_FIELDS = [ |
Collaborator
There was a problem hiding this comment.
I'm concerned this isn't going to scale well, especially when we start adding new forms or versioning them. Thoughts on shifting to a more configuration driven approach, where we could annotate fields or have a mapping object per form template that talks about how that form template's fields map to SGM concepts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8926
Changes proposed
application_submission_number/project_title/total_requested_amountwhen creating the application submissionContext for reviewers
These are all fields we want for award recommendation work as they're needed in the UI we display to grantors. They're all nullable, although with the way this is written, the new submission number won't ever be. The others can be null if the fields for them aren't present.
https://navasage.atlassian.net/wiki/spaces/Grantsgov/pages/2735046679/Tech+Spec+-+Award+Recommendation+Data+Model+Initial+Endpoints#Application-Submission
Validation steps
Will test manually (besides the tests written) once it's in staging - my local setup needs a bit of fixing to work with the frontend / handle submission all the way through.