Conversation
We have several variants for the BYB page and I would say that we should either: - make a separate template for each - use one template for all of them with a bunch of 'if' statements Since the content overlaps so heavily, I am going with option 2. This change does move the BYB page template out of the main nofo_view template, however, as that does seem to add a lot of noise.
This was accidentally removed in a past PR, so we need to add it back in.
Collaborator
Author
|
Works! Shipping it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates all the BYB options into 1 template partial.
We have three variants for the BYB page currently and I would say that we should either:
Since the content overlaps so heavily, I am going with option 2.
This change does move the BYB page template out of the main
nofo_viewtemplate, however, as that does seem to add a lot of noise.It also re-adds the
nofo.inline_cssblock, which allows us to do CSS overrides to individual NOFOs.