Merged
Conversation
Tighten GrabzIt cookie scoping for DOCX export by binding custom cookies to the export URL host instead of the incoming request host, and add validation/logging to fail fast when the host or session context does not match. This prevents cross-domain cookie mixups between dev and prod that were causing GrabzIt to send the wrong sessionid/csrftoken and get redirected to login instead of exporting the document.
pcraig3
force-pushed
the
stronger-cookies
branch
from
fb002a9 to
021893b
Compare
It doesn't really need one, but it looks nicer this way.
pcraig3
force-pushed
the
stronger-cookies
branch
from
021893b to
da9dc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes how cookies are set for the Grabzit download feature.
Details
This PR tighten GrabzIt's cookie scoping for DOCX export by binding custom cookies to the export URL host instead of the incoming request host, and adds validation/logging to fail fast when the host or session
context does not match.
This (hopefully) prevents cross-domain cookie mixups between dev and prod that were causing GrabzIt to send the wrong sessionid/csrftoken and get redirected to login instead of exporting the document.
Another thing this PR does is that it adds a
titleelement to the export template.I am pretty sure this PR solves #646